Skip to contentSkip to conversation

drivers/scsi/aic7xxx/* - compile warning cleanup

KJ Domen Puncer 1 participant 1 message Feb 19, 2005 Kernel janitors

lore
Share & tools
lore

Domen Puncer

author
#0 lore raw

On 15/02/05 00:02 +0200, Stephen Biggs wrote:
Content-Description: Mail message body

Quoted 9 lines

Description: compile warning cleanup - handle error return from scsi_add_host

Signed-off-by Stephen Biggs <[email protected]>

diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm2-original/drivers/scsi/aic7xxx/aic79xx_osm.c linux-2.6.11-rc3-mm2/drivers/scsi/aic7xxx/aic79xx_osm.c

drivers/scsi/aic7xxx/aic79xx_osm.c ahd_linux_register_host(struct ahd_softc · line 2069

Quoted 6 lines
drivers/scsi/aic7xxx/aic79xx_osm.c +2 -1
@@ -2065,7 +2065,8 @@ ahd_linux_register_host(struct ahd_softc
 	ahd_unlock(ahd, &s);
 
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,0)
-	scsi_add_host(host, &ahd->dev_softc->dev); /* XXX handle failure */
+	if (scsi_add_host(host, &ahd->dev_softc->dev))
+		return (EIO);

If it was that simple, I doubt they'd wrote the comment :-) Everything has to be "undone" before return.

Domen

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors