unexport do_settimeofday
Subsystems (13)
PATCH 1/1 unexport do_settimeofday
I haven't found any possible modular usage of do_settimeofday in the kernel.
---
This patch was already sent on:
- 20 Jan 2005
arch/alpha/kernel/time.c | 2 -- arch/arm/kernel/time.c | 2 -- arch/arm26/kernel/time.c | 2 -- arch/cris/kernel/time.c | 2 -- arch/h8300/kernel/time.c | 2 -- arch/i386/kernel/time.c | 2 -- arch/m32r/kernel/time.c | 2 -- arch/m68k/kernel/time.c | 2 -- arch/m68knommu/kernel/time.c | 1 - arch/mips/dec/time.c | 2 -- arch/mips/kernel/time.c | 2 -- arch/parisc/kernel/time.c | 1 - arch/ppc/kernel/time.c | 2 -- arch/ppc64/kernel/time.c | 2 -- arch/s390/kernel/time.c | 2 -- arch/sh/kernel/time.c | 2 -- arch/sparc/kernel/time.c | 2 -- arch/um/kernel/ksyms.c | 1 - arch/v850/kernel/time.c | 2 -- arch/x86_64/kernel/time.c | 2 -- 20 files changed, 37 deletions(-)
arch/i386/kernel/time.c renamed from arch/i386/kernel/time.c.old +0 -2
@@ -169,8 +169,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -static int set_rtc_mmss (unsigned long nowtime) {int retval;
arch/arm/kernel/time.c renamed from arch/arm/kernel/time.c.old +0 -2
@@ -301,8 +301,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -/** * save_time_delta - Save the offset between system time and RTC time * @delta: pointer to timespec to store delta
arch/sparc/kernel/time.c renamed from arch/sparc/kernel/time.c.old +0 -2
@@ -530,8 +530,6 @@return ret; } -EXPORT_SYMBOL (do_settimeofday); -static int sbus_do_settimeofday (struct timespec *tv) {time_t wtm_sec, sec = tv->tv_sec;
arch/ppc/kernel/time.c renamed from arch/ppc/kernel/time.c.old +0 -2
@@ -285,8 +285,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -/* This function is only called on the boot processor */ void __init time_init (void ) {
arch/mips/dec/time.c renamed from arch/mips/dec/time.c.old +0 -2
@@ -189,8 +189,6 @@CMOS_WRITE (RTC_REF_CLCK_32KHZ | (16 -LOG_2_HZ ),RTC_REG_A ); } -EXPORT_SYMBOL (do_settimeofday); -void __init dec_timer_setup (struct irqaction *irq) {setup_irq (dec_interrupt[DEC_IRQ_RTC ], irq);
arch/mips/kernel/time.c renamed from arch/mips/kernel/time.c.old +0 -2
@@ -234,8 +234,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -/* * Gettimeoffset routines. These routines returns the time duration * since last timer interrupt in usecs.
arch/m68knommu/kernel/time.c renamed from arch/m68knommu/kernel/time.c.old +0 -1
@@ -195,4 +195,3 @@return (unsigned long long )jiffies * (1000000000 /HZ ); } -EXPORT_SYMBOL (do_settimeofday);
arch/sh/kernel/time.c renamed from arch/sh/kernel/time.c.old +0 -2
@@ -254,8 +254,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -/* last time the RTC clock got updated */ static long last_rtc_update;
arch/cris/kernel/time.c renamed from arch/cris/kernel/time.c.old +0 -2
@@ -122,8 +122,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -/* * BUG: This routine does not handle hour overflow properly; it just
arch/arm26/kernel/time.c renamed from arch/arm26/kernel/time.c.old +0 -2
@@ -198,8 +198,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -static irqreturn_t timer_interrupt (int irq,void *dev_id,struct pt_regs *regs) {do_timer (regs);
arch/m68k/kernel/time.c renamed from arch/m68k/kernel/time.c.old +0 -2
@@ -175,8 +175,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -/* * Scheduler clock - returns current time in ns units. */
arch/alpha/kernel/time.c renamed from arch/alpha/kernel/time.c.old +0 -2
@@ -512,8 +512,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -/* * In order to set the CMOS clock precisely, set_rtc_mmss has to be
arch/ppc64/kernel/time.c renamed from arch/ppc64/kernel/time.c.old +0 -2
@@ -424,8 +424,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -void __init time_init (void ) {/* This function is only called on the boot processor */
arch/um/kernel/ksyms.c renamed from arch/um/kernel/ksyms.c.old +0 -1
@@ -95,7 +95,6 @@EXPORT_SYMBOL (dump_thread);EXPORT_SYMBOL (do_gettimeofday); -EXPORT_SYMBOL (do_settimeofday);/* This is here because UML expands open to sys_open, not to a system * call instruction.
arch/parisc/kernel/time.c renamed from arch/parisc/kernel/time.c.old +0 -1
@@ -197,7 +197,6 @@clock_was_set ();return 0 ; } -EXPORT_SYMBOL (do_settimeofday);/* * XXX: We can do better than this.
arch/h8300/kernel/time.c renamed from arch/h8300/kernel/time.c.old +0 -2
@@ -125,8 +125,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -unsigned long long sched_clock (void ) {return (unsigned long long )jiffies * (1000000000 /HZ );
arch/m32r/kernel/time.c renamed from arch/m32r/kernel/time.c.old +0 -2
@@ -181,8 +181,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -/* * In order to set the CMOS clock precisely, set_rtc_mmss has to be * called 500 ms after the second nowtime has started, because when
arch/x86_64/kernel/time.c renamed from arch/x86_64/kernel/time.c.old +0 -2
@@ -179,8 +179,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -unsigned long profile_pc (struct pt_regs *regs) {unsigned long pc =instruction_pointer (regs);
arch/s390/kernel/time.c renamed from arch/s390/kernel/time.c.old +0 -2
@@ -148,8 +148,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -#ifdef CONFIG_PROFILING #define s390_do_profile (regs) profile_tick(CPU_PROFILING, regs)
arch/v850/kernel/time.c renamed from arch/v850/kernel/time.c.old +0 -2
@@ -179,8 +179,6 @@return 0 ; } -EXPORT_SYMBOL (do_settimeofday); -static int timer_dev_id;static struct irqaction timer_irqaction = { timer_interrupt,
Quoted 4 lines · Adrian Bunk
I haven't found any possible modular usage of
do_settimeofdayin the kernel.
Please,
- Add deprecated_if_module
- Use it for do_settimeofday()
- Add do_settimeofday to Documentation/feature-removal-schedule.txt
Quoted 6 lines · Andrew Morton
Quoted 4 lines · Adrian Bunk
I haven't found any possible modular usage of
do_settimeofdayin the kernel.
Quoted 8 lines
Please,
- Add
deprecated_if_module- Use it for
do_settimeofday()- Add
do_settimeofdaytoDocumentation/feature-removal-schedule.txt-
for _set_ time of day? I really can't imagine anyone messing with that. _get_... sure. but set???
Quoted 12 lines · Arjan van de Ven
Quoted 10 lines · Andrew Morton
Quoted 4 lines · Adrian Bunk
I haven't found any possible modular usage of
do_settimeofdayin the kernel.Please,
- Add
deprecated_if_module
Quoted 7 lines
Quoted 4 lines
- Use it for
do_settimeofday()- Add
do_settimeofdaytoDocumentation/feature-removal-schedule.txt-for _set_ time of day? I really can't imagine anyone messing with that. _get_... sure. but set???
Sure. But there must have been a reason to export it in the first place.
I don't see much point in playing these games. Deprecate it, pull it out next year, done.
Quoted 15 lines · Andrew Morton
Quoted 14 lines · Arjan van de Ven
Quoted 12 lines · Andrew Morton
Quoted 4 lines · Adrian Bunk
I haven't found any possible modular usage of
do_settimeofdayin the kernel.Please,
- Add
deprecated_if_module- Use it for
do_settimeofday()
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
- Add
do_settimeofdaytoDocumentation/feature-removal-schedule.txt-for _set_ time of day? I really can't imagine anyone messing with that. _get_... sure. but set???
Sure. But there must have been a reason to export it in the first place.
sloppy coding?
Quoted 8 lines · Bartlomiej Zolnierkiewicz
Quoted 5 lines · Andrew Morton
Quoted 2 lines · Adrian Bunk
I haven't found any possible modular usage of
do_settimeofdayin the kernel.Sure. But there must have been a reason to export it in the first place.
sloppy coding?
Who knows? Maybe someone developed a kernel module that interfaces to an unusual clock chip on their motherboard. IMHO, all of this "_I_ don't see any use for it, lets get rid of it because it's not useful" changing is just a source of grief for anyone that doesn't have their code in the kernel.
Cheers, Andreas
--
Andreas Dilger
Quoted 8 lines · Andreas Dilger
Quoted 7 lines · Bartlomiej Zolnierkiewicz
Quoted 5 lines · Andrew Morton
Quoted 2 lines · Adrian Bunk
I haven't found any possible modular usage of
do_settimeofdayin the kernel.Sure. But there must have been a reason to export it in the first place.
Quoted 7 lines
Quoted 1 line
sloppy coding?
Who knows? Maybe someone developed a kernel module that interfaces to an unusual clock chip on their motherboard. IMHO, all of this "_I_ don't see any use for it, lets get rid of it because it's not useful" changing is just a source of grief for anyone that doesn't have their code in the kernel.
actually exports cause kernels to be bigger. Some of these exports aren't even used in the kernel entirely, others cause the kernel to be bigger just by being non-static and having the symbol structures there. A lot of them are "you really shouldn't" APIs.
By your argument, why bother with exports at all?
Quoted 4 lines · Arjan van de Ven
actually exports cause kernels to be bigger. Some of these exports aren't even used in the kernel entirely, others cause the kernel to be bigger just by being non-static and having the symbol structures there.
Yup. IOW, this problem is so vanishingly teensy-weensy as to be almost not a problem at all. So we can wait 6-12 months before fixing it.
Quoted 1 line
A lot of them are "you really shouldn't" APIs.
Sure. That's why we should remove the export.
Quoted 10 lines · Andrew Morton
Quoted 4 lines · Adrian Bunk
I haven't found any possible modular usage of
do_settimeofdayin the kernel.Please,
- Add
deprecated_if_module
...
What's the correct header file for __deprecated_if_module ? module.h ?
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 8 lines · Adrian Bunk
Quoted 6 lines · Andrew Morton
Quoted 4 lines · Adrian Bunk
I haven't found any possible modular usage of
do_settimeofdayin the kernel.
Quoted 6 lines
Quoted 4 lines
Please,
- Add
deprecated_if_module
...What's the correct header file for
__deprecated_if_module?
Actually, __deprecated_in_modules would be a better name.
Quoted 1 line
module.h?
compiler.h, I guess.
include/linux/compiler.h renamed from include/linux/compiler.h~a +6 -0
@@ -86,6 +86,12 @@ extern void __chk_io_ptr(void __iomem *)# define __deprecated/* unimplemented */ #endif +#ifdef MODULE +#define __deprecated_in_modules __deprecated +#else +#define __deprecated_in_modules/* OK in non-modular code */ +#endif +#ifndef __must_check#define __must_check#endif
_
Quoted 4 lines · Andrew Morton
...
include/linux/compiler.h extern void __chk_io_ptr(void __iomem *) · line 94
Quoted 10 lines
include/linux/compiler.h renamed from include/linux/compiler.h~a +6
-0@@ -86,6 +86,12 @@ extern void __chk_io_ptr(void __iomem *)# define __deprecated/* unimplemented */ #endif +#ifdef MODULE +#define __deprecated_in_modules __deprecated +#else +#define __deprecated_in_modules/* OK in non-modular code */ +#endif +
Looks good.
One more question:
You get a false positive if the file containing the symbol is itself a module.
Is there any way to solve this without additional #define's and #ifdef's for each symbol?
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 12 lines · Adrian Bunk
include/linux/compiler.h extern void __chk_io_ptr(void __iomem *) · line 94
Quoted 8 lines
include/linux/compiler.h renamed from include/linux/compiler.h~a +6
-0+#ifdef MODULE +#define __deprecated_in_modules __deprecated +#else +#define __deprecated_in_modules/* OK in non-modular code */ +#endif +Looks good.
Quoted 4 lines
One more question:
You get a false positive if the file containing the symbol is itself a module.
I don't understand what you mean.
You mean that a module is doing an EXPORT_SYMBOL of a symbol which is on death row?
If so: err, not sure. I guess we could just live with the warning.
Quoted 2 lines
Is there any way to solve this without additional #define's and #ifdef's for each symbol?
Not that I can think of.
Quoted 18 lines · Andrew Morton
Quoted 12 lines · Adrian Bunk
include/linux/compiler.h extern void __chk_io_ptr(void __iomem *) · line 94
Quoted 8 lines
include/linux/compiler.h renamed from include/linux/compiler.h~a +6
-0+#ifdef MODULE +#define __deprecated_in_modules __deprecated +#else +#define __deprecated_in_modules/* OK in non-modular code */ +#endif +Looks good.
Quoted 4 lines
One more question:
You get a false positive if the file containing the symbol is itself a module.
Quoted 6 lines
I don't understand what you mean.
You mean that a module is doing an
EXPORT_SYMBOLof a symbol which is on death row?If so: err, not sure. I guess we could just live with the warning.
also those should be rare; it's certainly not a "core" export that 3rd party stuff depends on but most of the time just accidentally exported (by people who thought that they needed EXPORT_SYMBOL to glue two .c files into the same one .o module)
PATCH 1/1 deprecate EXPORT_SYMBOL(do_settimeofday)
In reply to Andrew MortonDocumentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +7 -0
@@ -32,3 +32,10 @@ /sys/devices/system/cpu/cpu%n/cpufreq/. Who: Dominik Brodowski <[email protected]> +--------------------------- + +What: EXPORT_SYMBOL(do_settimeofday) +When: 26 Aug 2005 +Files: arch/*/kernel/time.c +Why: not used in the kernel +Who: Adrian Bunk <[email protected]>
include/linux/time.h renamed from include/linux/time.h.old +1 -1
@@ -93,7 +93,7 @@#define CURRENT_TIME_SEC ((struct timespec) { xtime.tv_sec, 0 })extern void do_gettimeofday (struct timeval *tv); -extern int do_settimeofday (struct timespec *tv); +extern int __deprecated_in_modules do_settimeofday(struct timespec *tv);extern int do_sys_settimeofday (struct timespec *tv,struct timezone *tz);extern void clock_was_set (void );// call when ever the clock is set extern int do_posix_clock_monotonic_gettime (struct timespec *tp);
Re: [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday)
In article <[email protected]> (at Sat, 26 Feb 2005 14:33:37 +0100), Adrian Bunk <[email protected]> says:
Documentation/feature-removal-schedule.txt line 38
Quoted 3 lines
Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +3
-0+ +What: EXPORT_SYMBOL(do_settimeofday) +When: 26 Aug 2005
~~~ Feb?
Documentation/feature-removal-schedule.txt line 41
Quoted 3 lines
Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +3
-0+Files: arch/*/kernel/time.c +Why: not used in the kernel +Who: Adrian Bunk <[email protected]>
--yoshfuji
Re: [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday)
In article <[email protected]> (at Sat, 26 Feb 2005 22:37:42 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <[email protected]> says:
Quoted 10 lines
In article <[email protected]> (at Sat, 26 Feb 2005 14:33:37 +0100), Adrian Bunk <[email protected]> says:
Documentation/feature-removal-schedule.txt line 38
Quoted 3 lines
Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +3
-0+ +What: EXPORT_SYMBOL(do_settimeofday) +When: 26 Aug 2005~~~ Feb?Documentation/feature-removal-schedule.txt line 41
Quoted 3 lines
Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +3
-0+Files: arch/*/kernel/time.c +Why: not used in the kernel +Who: Adrian Bunk <[email protected]>
oops, I was wrong. This is schedule. sorry.
--yoshfuji
Re: [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday)
In reply to Adrian BunkQuoted 1 line · Adrian Bunk
Signed-off-by Adrian Bunk <[email protected]>
Please don't deprecate this symbol. ARM has a large variety of RTC implementations, some of which reside in I2C modules which are yet to be merged.
Firstly, these aren't accessible until the i2c subsystem has been initialised. Secondly, i2c is modular, so this function must be accessible from a module in order for the system time/date to be initialised from the RTC with a modular build.
(It can be argued that you wouldn't want to build such a thing as a module in the first place, in which case removing the export would of course be fine. However, we can't sanely force I2C to be either always builtin, and placing this expectation on people will eventually lead other janitors to complain that the symbol is used by modules but isn't exported.)
Signature · 4 lines
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial coreQuoted 15 lines · Andrew Morton
Quoted 14 lines · Adrian Bunk
include/linux/compiler.h extern void __chk_io_ptr(void __iomem *) · line 94
Quoted 8 lines
include/linux/compiler.h renamed from include/linux/compiler.h~a +6
-0+#ifdef MODULE +#define __deprecated_in_modules __deprecated +#else +#define __deprecated_in_modules/* OK in non-modular code */ +#endif +Looks good.
One more question:
Quoted 7 lines
Quoted 2 lines
You get a false positive if the file containing the symbol is itself a module.
I don't understand what you mean.
You mean that a module is doing an
EXPORT_SYMBOLof a symbol which is on death row?
Yes.
Quoted 2 lines
If so: err, not sure. I guess we could just live with the warning.
...
OK.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 11 lines · Arjan van de Ven
Quoted 10 lines · Andrew Morton
Quoted 3 lines · Adrian Bunk
You get a false positive if the file containing the symbol is itself a module.
I don't understand what you mean.
You mean that a module is doing an
EXPORT_SYMBOLof a symbol which is on death row?
Quoted 6 lines
Quoted 1 line
If so: err, not sure. I guess we could just live with the warning.
also those should be rare; it's certainly not a "core" export that 3rd party stuff depends on but most of the time just accidentally exported (by people who thought that they needed
EXPORT_SYMBOLto glue two .c files into the same one .o module)
Some subsystems (e.g. PCMCIA, USB, ALSA, IDE, Firewire, ISDN, I2C, IPv6, SCSI) can be built completely modular and will therefore experience this issue if any symbol in them is __deprecated_in_modules.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedRe: [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday)
In reply to Russell KingQuoted 11 lines · Russell King
On Sat, Feb 26, 2005 at 02:33:37PM +0100, Adrian Bunk wrote:
Please don't deprecate this symbol. ARM has a large variety of RTC implementations, some of which reside in I2C modules which are yet to be merged.
Firstly, these aren't accessible until the i2c subsystem has been initialised. Secondly, i2c is modular, so this function must be accessible from a module in order for the system time/date to be initialised from the RTC with a modular build.
Quoted 6 lines
(It can be argued that you wouldn't want to build such a thing as a module in the first place, in which case removing the export would of course be fine. However, we can't sanely force I2C to be either always builtin, and placing this expectation on people will eventually lead other janitors to complain that the symbol is used by modules but isn't exported.)
I saw drivers/acorn/char/i2c.c, but this file is always built statically on ARCH_ACORN without any dependency between ARCH_ACORN and I2C. This is buggy.
Why can't such drivers select I2C and other required I2C_* variables?
Appropriate depends or selects are required in any case. If you plan to make drivers like drivers/acorn/char/i2c.c modular, my patch is void.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedRe: [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday)
Quoted 23 lines · Adrian Bunk
Quoted 11 lines · Russell King
On Sat, Feb 26, 2005 at 02:33:37PM +0100, Adrian Bunk wrote:
Please don't deprecate this symbol. ARM has a large variety of RTC implementations, some of which reside in I2C modules which are yet to be merged.
Firstly, these aren't accessible until the i2c subsystem has been initialised. Secondly, i2c is modular, so this function must be accessible from a module in order for the system time/date to be initialised from the RTC with a modular build.
Quoted 6 lines
(It can be argued that you wouldn't want to build such a thing as a module in the first place, in which case removing the export would of course be fine. However, we can't sanely force I2C to be either always builtin, and placing this expectation on people will eventually lead other janitors to complain that the symbol is used by modules but isn't exported.)
I saw
drivers/acorn/char/i2c.c, but this file is always built statically onARCH_ACORNwithout any dependency betweenARCH_ACORNand I2C. This is buggy.
Quoted 5 lines
Why can't such drivers select I2C and other required I2C_* variables?
Appropriate depends or selects are required in any case. If you plan to make drivers like
drivers/acorn/char/i2c.cmodular, my patch is void.
That driver is buggy for other reasons, but thankfully doesn't show itself very often...
However, that isn't the one I was talking about, since I was talking about an unmerged driver.
There are a number of ARM platforms which use a Ricoh RTC chip, and the driver for this will live in drivers/i2c/chips/ricoh-rtc.c. This is a stand alone driver in its own sense, handling the power management issues (saving the time offset/restoring the time) and setting the system time upon its initialisation. (In turn, this requires some i2c patches which add power management to the i2c subsystem to be merged first.)
It's already used in some ARM platforms, including one which I was involved in. It just hasn't been merged.
As far as drivers/acorn/char i2c rtc stuff goes, I plan to make this a full and proper i2c citizen, so adding breakage to the Kconfig with random select statements for publically viewable symbols isn't the way to go.
Signature · 4 lines
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial coreRe: [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday)
Quoted 9 lines · Russell King
...
There are a number of ARM platforms which use a Ricoh RTC chip, and the driver for this will live indrivers/i2c/chips/ricoh-rtc.c. This is a stand alone driver in its own sense, handling the power management issues (saving the time offset/restoring the time) and setting the system time upon its initialisation. (In turn, this requires some i2c patches which add power management to the i2c subsystem to be merged first.)
Quoted 7 lines
It's already used in some ARM platforms, including one which I was involved in. It just hasn't been merged.
As far as
drivers/acorn/chari2c rtc stuff goes, I plan to make this a full and proper i2c citizen, so adding breakage to theKconfigwith random select statements for publically viewable symbols isn't the way to go.
You call it "breakage" because you have a relatively dogmatic view regarding the selection of user visible symbols.
Other people care more about the usability of the kernel config system, and therefore a select of one of the I2C* options is quite common from both outside and inside the i2c subsystem.
There are two possbile situations:
- these RTC drivers are nice add-ons that could be shown if all required I2C* options are already enabled
- these RTC drivers are pretty essential and should really be enabled on the platforms they are for
Which of these two cases describes the situation of these RTC drivers?
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedRe: [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday)
Quoted 6 lines · Adrian Bunk
You call it "breakage" because you have a relatively dogmatic view regarding the selection of user visible symbols.
Other people care more about the usability of the kernel config system, and therefore a select of one of the I2C* options is quite common from both outside and inside the i2c subsystem.
Quoted 7 lines
There are two possbile situations:
- these RTC drivers are nice add-ons that could be shown if all required I2C* options are already enabled
- these RTC drivers are pretty essential and should really be enabled on the platforms they are forWhich of these two cases describes the situation of these RTC drivers?
Since RTCs aren't _actually_ essential for Linux kernel operation, the former clearly applies.
Other people may have differing opinions, but having worked with a large number of SoC platforms where the RTC is reset when the SoC is reset, or even platforms where there is no RTC at all, it brings a different perspective to this that people who have only ever experienced systems where the RTC is always true do not have.
Signature · 4 lines
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial coreRe: [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday)
In reply to Adrian BunkQuoted 5 lines · Adrian Bunk
You call it "breakage" because you have a relatively dogmatic view regarding the selection of user visible symbols.
Other people care more about the usability of the kernel config system, and therefore a select of one of the I2C* options is quite common from both outside and inside the i2c subsystem.
I think you have to realise that we're different in the ARM world. We tend to rely on the default configuration files to come out with something that works, rather than hard coding the "what works" into the kernel configuration subsystem.
If you want to see an example of this kind of "usability" approach, take a look at arch/arm/Kconfig LEDS options - lines of 250 or so characters of dependencies. Not what I'd call particularly maintainable.
That is what your approach has in store for the other Kconfig files when it comes down to getting dependencies Correct(tm).
(I do have a simplified LEDS configuration set, but it still keeps one huge LEDS dependency.)
Signature · 4 lines
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial coreRe: [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday)
In reply to Russell KingQuoted 15 lines · Russell King
Quoted 6 lines · Adrian Bunk
You call it "breakage" because you have a relatively dogmatic view regarding the selection of user visible symbols.
Other people care more about the usability of the kernel config system, and therefore a select of one of the I2C* options is quite common from both outside and inside the i2c subsystem.Quoted 7 lines
There are two possbile situations:
- these RTC drivers are nice add-ons that could be shown if all required I2C* options are already enabled
- these RTC drivers are pretty essential and should really be enabled on the platforms they are forWhich of these two cases describes the situation of these RTC drivers?
Quoted 8 lines
Since RTCs aren't _actually_ essential for Linux kernel operation, the former clearly applies.
Other people may have differing opinions, but having worked with a large number of SoC platforms where the RTC is reset when the SoC is reset, or even platforms where there is no RTC at all, it brings a different perspective to this that people who have only ever experienced systems where the RTC is always true do not have.
No problem with this.
I'm hereby withdrawing my patch.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedRe: [2.6 patch] deprecate EXPORT_SYMBOL(do_settimeofday)
In reply to Russell KingQuoted 12 lines · Russell King
Quoted 5 lines · Adrian Bunk
You call it "breakage" because you have a relatively dogmatic view regarding the selection of user visible symbols.
Other people care more about the usability of the kernel config system, and therefore a select of one of the I2C* options is quite common from both outside and inside the i2c subsystem.I think you have to realise that we're different in the ARM world. We tend to rely on the default configuration files to come out with something that works, rather than hard coding the "what works" into the kernel configuration subsystem.
Quoted 7 lines
If you want to see an example of this kind of "usability" approach, take a look at
arch/arm/KconfigLEDS options - lines of 250 or so characters of dependencies. Not what I'd call particularly maintainable.That is what your approach has in store for the other
Kconfigfiles when it comes down to getting dependencies Correct(tm).
LEDS=n and LEDS_TIMER=y is a legal configuration if ARCH_EBSA110?
The LEDS_TIMER dependencies seem to be incorrect at least regarding ARCH_CDB89712.
Yes, it is ugly annd error-prone.
Quoted 2 lines
(I do have a simplified LEDS configuration set, but it still keeps one huge LEDS dependency.)
The current LEDS configuration is ugly, but that's not an ARM specific problem. Compare e.g. the big #if in include/linux/parport.h 30 lines before the end of the file in Linus' tree and see how this is resolved in -mm in non-pc-parport-config-change.patch .
One solution for LEDS would be to add a helper option HAS_LEDS that gets selected by the ARCH_* options if the platform supports LEDS, and LEDS simply depends on HAS_LEDS.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 4 lines · Andrew Morton
Quoted 2 lines
for _set_ time of day? I really can't imagine anyone messing with that. _get_... sure. but set???
Sure. But there must have been a reason to export it in the first place.
NO. Speaking from experience there's tons of totally pointless exports.
Quoted 2 lines
I don't see much point in playing these games. Deprecate it, pull it out next year, done.
Sorry, but without a development tree we don't want to play these deprecation forever games. If you want a longer warning period open 2.7 now that we can work ahead there and leave 2.6 alone. But restricting all kinds of totally sane things from going in just doesn't work out.