Skip to contentSkip to conversation

fix module paramater permissions in radeon_base.c

PATCH In review Greg KH 2 participants 2 messages Mar 2, 2005 Framebuffer layer

lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 1/1 fix module paramater permissions in radeon_base.c

You really don't want -2 for the file mode in sysfs. It creates:
-rwsrwsrwT 1 root root 4096 Mar 1 22:59 /sys/module/radeonfb/parameters/default_dynclk

on my box. Here's a fix against a clean 2.6.11-rc5 kernel, please forward onward as you see fit.

Signed-off-by Greg Kroah-Hartman <[email protected]>
drivers/video/aty/radeon_base.c +1 -1
@@ -2551,7 +2551,7 @@
 MODULE_DESCRIPTION("framebuffer driver for ATI Radeon chipset");
 MODULE_LICENSE("GPL");
 module_param(noaccel, bool, 0);
-module_param(default_dynclk, int, -2);
+module_param(default_dynclk, int, 0);
 MODULE_PARM_DESC(default_dynclk, "int: -2=enable on mobility only,-1=do not change,0=off,1=on");
 MODULE_PARM_DESC(noaccel, "bool: disable acceleration");
 module_param(nomodeset, bool, 0);
#1 lore raw
Quoted 13 lines · Greg KH

You really don't want -2 for the file mode in sysfs. It creates:
-rwsrwsrwT 1 root root 4096 Mar 1 22:59 /sys/module/radeonfb/parameters/default_dynclk

on my box. Here's a fix against a clean 2.6.11-rc5 kernel, please forward onward as you see fit.

Signed-off-by Greg Kroah-Hartman <[email protected]>

drivers/video/aty/radeon_base.c line 2557

Quoted 8 lines
drivers/video/aty/radeon_base.c +1 -1
@@ -2551,7 +2551,7 @@
 MODULE_DESCRIPTION("framebuffer driver for ATI Radeon chipset");
 MODULE_LICENSE("GPL");
 module_param(noaccel, bool, 0);
-module_param(default_dynclk, int, -2);
+module_param(default_dynclk, int, 0);
 MODULE_PARM_DESC(default_dynclk, "int: -2=enable on mobility only,-1=do not change,0=off,1=on");
 MODULE_PARM_DESC(noaccel, "bool: disable acceleration");
 module_param(nomodeset, bool, 0);

Right, that is bogus, thanks.

Ben.