Skip to contentSkip to conversation

Fix ROSE security hole

PATCH In review Ralf Baechle 2 participants 2 messages Mar 2, 2005 – Mar 11, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix ROSE security hole

ROSE wasn't verifying the ndigis argument of a new route resulting in a minor security hole.

net/rose/rose_route.c +2 -1
Index: bk-afu/net/rose/rose_route.c
===================================================================
@@ -727,7 +727,8 @@
 		}
 		if (rose_route.mask > 10) /* Mask can't be more than 10 digits */
 			return -EINVAL;
-
+		if (rose_route.ndigis > 8) /* No more than 8 digipeats */
+			return -EINVAL;
 		err = rose_add_node(&rose_route, dev);
 		dev_put(dev);
 		return err;
maintainer
#1 lore raw
Quoted 2 lines · On Wed, 2 Mar 2005 09:06:58 +0000 Ralf Baechle <[email protected]> wrote:

ROSE wasn't verifying the ndigis argument of a new route resulting in a minor security hole.

Also applied, thanks Ralf.