char/ds1620: use msleep() instead of schedule_timeout()
Subsystems (2)
PATCH 1/1 char/ds1620: use msleep() instead of schedule_timeout()
Hi,
Not sure why any driver needs to sleep for *two* ticks, so let's fix it.
Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected. Signals are never checked for by the callers or in the function itself, so use TASK_UNINTERRUPTIBLE instead of TASK_INTERRUPTIBLE. The delay is presumed to have been written when HZ==100, and thus has been multiplied by 10 to pass to msleep().
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/char/ds1620.c +1 -2
@@ -163,8 +163,7 @@ static void ds1620_out(int cmd, int bitsnetwinder_ds1620_reset ();netwinder_unlock (&flags); -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (2 ); +msleep (20 ); }static unsigned int ds1620_in (int cmd,int bits)
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors