Skip to contentSkip to conversation

hweight: typecast return types

PATCH New Randy.Dunlap 1 participant 1 message Mar 3, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hweight: typecast return types

Make hweight() macros return unsigned int for 8,16,32 bits, instead of requiring callers to do that.

drivers/input/joystick/analog.c:414: warning: int format, different type arg (arg 3) drivers/input/joystick/analog.c:414: warning: int format, different type arg (arg 4) drivers/input/joystick/analog.c:418: warning: int format, different type arg (arg 4)

Note: does not address parisc, s390, or sparc64... waiting for comments.

diffstat:=

 include/asm-alpha/bitops.h |    6 +++---
 include/asm-ia64/bitops.h  |    6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
include/asm-alpha/bitops.h renamed from include/asm-alpha/bitops.h~hweight_types +3 -3
diff -Naurp ./include/asm-alpha/bitops.h~hweight_types ./include/asm-alpha/bitops.h
@@ -353,9 +353,9 @@ static inline unsigned long hweight64(un
 	return __kernel_ctpop(w);
 }
 
-#define hweight32(x) hweight64((x) & 0xfffffffful)
-#define hweight16(x) hweight64((x) & 0xfffful)
-#define hweight8(x)  hweight64((x) & 0xfful)
+#define hweight32(x)	(unsigned int) hweight64((x) & 0xfffffffful)
+#define hweight16(x)	(unsigned int) hweight64((x) & 0xfffful)
+#define hweight8(x)	(unsigned int) hweight64((x) & 0xfful)
 #else
 static inline unsigned long hweight64(unsigned long w)
 {
include/asm-ia64/bitops.h renamed from include/asm-ia64/bitops.h~hweight_types +3 -3
diff -Naurp ./include/asm-ia64/bitops.h~hweight_types ./include/asm-ia64/bitops.h
@@ -353,9 +353,9 @@ hweight64 (unsigned long x)
 	return result;
 }
 
-#define hweight32(x) hweight64 ((x) & 0xfffffffful)
-#define hweight16(x) hweight64 ((x) & 0xfffful)
-#define hweight8(x)  hweight64 ((x) & 0xfful)
+#define hweight32(x)	(unsigned int) hweight64((x) & 0xfffffffful)
+#define hweight16(x)	(unsigned int) hweight64((x) & 0xfffful)
+#define hweight8(x)	(unsigned int) hweight64((x) & 0xfful)
 
 #endif /* __KERNEL__ */
 

---