char/tty_io: replace schedule_timeout() with
Subsystems (2)
PATCH 1/1 char/tty_io: replace schedule_timeout() with
Hi,
Please consider applying.
Description: Use msleep_interruptible() instead of schedule_timeout() in send_break() to guarantee the task delays as expected. Change @duration's units to milliseconds, and modify arguments in callers appropriately. Patch is compile-tested.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/char/tty_io.c +4 -5
@@ -2171,12 +2171,11 @@ static int tiocsetd(struct tty_struct *treturn tty_set_ldisc (tty, ldisc); } -static int send_break (struct tty_struct *tty,int duration) +static int send_break (struct tty_struct *tty,unsigned int duration) { tty->driver->break_ctl (tty,-1 );if (!signal_pending (current)) { -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (duration); +msleep_interruptible (duration); } tty->driver->break_ctl (tty,0 );if (signal_pending (current))
@@ -2357,10 +2356,10 @@ int tty_ioctl(struct inode * inode, stru* all by anyone? */ if (!arg) -return send_break (tty,HZ /4 ); +return send_break (tty,250 );return 0 ;case TCSBRKP :/* support for POSIX tcsendbreak() */ -return send_break (tty, arg ? arg*(HZ /10 ) :HZ /4 ); +return send_break (tty, arg ? arg*100 :250 );case TIOCMGET :return tty_tiocmget (tty, file, p);
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors