isdn/capi: replace interruptible_sleep_on() with wait_event_interruptible()]
PATCH 2/8 isdn/capi: replace interruptible_sleep_on() with wait_event_interruptible()]
Quoted 17 lines · Domen Puncer
Quoted 17 lines
Review
Quoted 12 lines
(quoted diff) +2
-7- for (;;) { - interruptible_sleep_on(&cdev->recvwait); - if ((skb = skb_dequeue(&cdev->recvqueue)) != 0) - break; - if (signal_pending(current)) - break; - } + wait_event_interruptible(cdev->recvwait, + ((skb = skb_dequeue(&cdev->recvqueue)) == 0)); if (skb == 0) return -ERESTARTNOHAND; }hmm, OK. Putting an expression with side-effect such as this into a macro which evaluates the expression multiple times is a bit of a worry, but it appears that everything will work OK.
Quoted 4 lines
Quoted 2 lines
That being said, I'd prefer that this come in via the ISDN team, after having been tested please.
I believe last update from ISDN team was 13 months ago. :-(
You are wrong. Last update was few weeks ago (not on the core).
Quoted 1 line
And I concur, testing would be great.
Will do that next week.
Signature · 3 lines
Karsten Keil SuSE Labs ISDN development