Skip to contentSkip to conversation

resync ATI PCI idents into base kernel

PATCH Greg KH 4 participants 8 messages Mar 8, 2005 – Mar 9, 2005 1 message not in the archive

lore
Share & tools
lore

Greg KH

author
#1 lore raw
In reply to a message not in the archive
Quoted 16 lines · Linux Kernel Mailing List

ChangeSet 1.1982.132.7, 2005/03/07 13:50:19-08:00, [email protected]

[PATCH] resync ATI PCI idents into base kernel

 pci_ids.h |   11 +++++++++++
 1 files changed, 11 insertions(+)

diff -Nru a/include/linux/pci_ids.h b/include/linux/pci_ids.h

include/linux/pci_ids.h +0 -0
@@ -352,10 +352,21 @@
 #define PCI_DEVICE_ID_ATI_RS300_133	0x5831
 #define PCI_DEVICE_ID_ATI_RS300_166	0x5832

include/linux/pci_ids.h line 363

Quoted 10 lines
include/linux/pci_ids.h +9 -0
 #define PCI_DEVICE_ID_ATI_RS300_200	0x5833
+#define PCI_DEVICE_ID_ATI_RS350_100     0x7830
+#define PCI_DEVICE_ID_ATI_RS350_133     0x7831
+#define PCI_DEVICE_ID_ATI_RS350_166     0x7832
+#define PCI_DEVICE_ID_ATI_RS350_200     0x7833
+#define PCI_DEVICE_ID_ATI_RS400_100     0x5a30
+#define PCI_DEVICE_ID_ATI_RS400_133     0x5a31
+#define PCI_DEVICE_ID_ATI_RS400_166     0x5a32
+#define PCI_DEVICE_ID_ATI_RS400_200     0x5a33
+#define PCI_DEVICE_ID_ATI_RS480         0x5950

Was there a reason you did this without using tabs, like the rest of the file?

Again, the maintainer chain is well documented...

{sigh}

Oh, no Signed-off-by: line either :(

greg k-h

#2 lore raw
Quoted 2 lines

Was there a reason you did this without using tabs, like the rest of the file?

No but I'll send Linus an update to fix that now.

Quoted 1 line

Again, the maintainer chain is well documented...

Really - so does it go to the PCI maintainer, the IDE maintainer or the DRI maintainer or someone else, or all of them, or in bits to different ones remembering there are dependancies and I don't use bitcreeper ?

Alan

#3 lore raw
Quoted 10 lines · Alan Cox
Quoted 2 lines

Was there a reason you did this without using tabs, like the rest of the file?

No but I'll send Linus an update to fix that now.

Quoted 1 line

Again, the maintainer chain is well documented...

Really - so does it go to the PCI maintainer, the IDE maintainer or the DRI maintainer or someone else, or all of them, or in bits to different ones remembering there are dependancies and I don't use bitcreeper ?

it should go to /dev/null because there are no users of these IDs ;-)

#4 lore raw
Quoted 5 lines · Bartlomiej Zolnierkiewicz
Quoted 3 lines

Really - so does it go to the PCI maintainer, the IDE maintainer or the DRI maintainer or someone else, or all of them, or in bits to different ones remembering there are dependancies and I don't use bitcreeper ?

it should go to /dev/null because there are no users of these IDs ;-)

See the problem - and I'm about to send you a patch so you can use the SI3112 driver with the ATI hardware because the Jeff Garzik one still fails for some users quite badly (and no I don't know why either).

Alan

#5 lore raw
In reply to Alan Cox
Quoted 10 lines · Alan Cox
Quoted 2 lines

Was there a reason you did this without using tabs, like the rest of the file?

No but I'll send Linus an update to fix that now.

Quoted 1 line

Again, the maintainer chain is well documented...

Really - so does it go to the PCI maintainer, the IDE maintainer or the DRI maintainer or someone else, or all of them, or in bits to different ones remembering there are dependancies and I don't use bitcreeper ?

If you don't know send it to Andrew.

#6 lore raw
Quoted 5 lines · Christoph Hellwig
Quoted 3 lines

Really - so does it go to the PCI maintainer, the IDE maintainer or the DRI maintainer or someone else, or all of them, or in bits to different ones remembering there are dependancies and I don't use bitcreeper ?

If you don't know send it to Andrew.

You are completely missing the point.

#7 lore raw
Quoted 8 lines · Alan Cox
Quoted 5 lines · Christoph Hellwig
Quoted 3 lines

Really - so does it go to the PCI maintainer, the IDE maintainer or the DRI maintainer or someone else, or all of them, or in bits to different ones remembering there are dependancies and I don't use bitcreeper ?

If you don't know send it to Andrew.

You are completely missing the point.

Which is? That's you're so special you don't need to care about the workflow the ordinary humans have created?

#8 lore raw
Quoted 2 lines · Christoph Hellwig

Which is? That's you're so special you don't need to care about the workflow the ordinary humans have created?

I don't see the connection between your comment and the thread sorry.

If I send it all to Andrew what will happen. Andrew can either break it into zillions of pieces and everyone will say "But why do we need this" or apply it. You might want to ask why so many new drivers don't bother using pci_ids.h, I'd venture to say its a defensive mechanism against broken process.

Alan