remove dead cyrix/centaur mtrr init code
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 3 lines · Linux Kernel Mailing List
ChangeSet 1.2094, 2005/03/08 09:40:59-08:00, [email protected]
[PATCH] remove dead cyrix/centaur mtrr init code
This patch was discussed previously and declared incorrect. The ->init method call is missing in the base mtrr code.
Should be reverted and/or fixed properly.
Quoted 2 lines · Alan Cox
This patch was discussed previously and declared incorrect.
Well, it was also declared as a "don't care" by Dave, I think, by virtue of nobody having ever complained.
Linus
Quoted 6 lines · Linus Torvalds
Quoted 2 lines · Alan Cox
This patch was discussed previously and declared incorrect.
Well, it was also declared as a "don't care" by Dave, I think, by virtue of nobody having ever complained.
And in further discussion people produced the relevant CPU's. Its a performance hit (30% on winchip).
Alan
Quoted 6 lines · Alan Cox
Quoted 1 line
[PATCH] remove dead cyrix/centaur mtrr init code
This patch was discussed previously and declared incorrect. The ->init method call is missing in the base mtrr code.
Should be reverted and/or fixed properly.
Hi Alan - a surprising reaction.
The patch is an improvement - it #ifdef's out some dead code. I sent you a follow-up patch that activates the dead code, since you said
I have one here running 2.4 still. I can test a 2.6 fix for the mtrr init happily enough.
But so far you have not replied.
The moment you report that the follow-up patch is fine, we can remove the #if 0 and insert the initcalls instead.
So, all is well today, and we are waiting for your report.
Andries
Quoted 4 lines · Andries Brouwer
The moment you report that the follow-up patch is fine, we can remove the #if 0 and insert the initcalls instead.
So, all is well today, and we are waiting for your report.
Ok works for me. I'll let you know ASAP.
Quoted 7 lines · Alan Cox
Quoted 4 lines · Andries Brouwer
The moment you report that the follow-up patch is fine, we can remove the #if 0 and insert the initcalls instead.
So, all is well today, and we are waiting for your report.
Ok works for me. I'll let you know ASAP.
Winchip works as well if you call the ->init, and it is much happier as a result.