Skip to contentSkip to conversation

debugfs fixes for 2.6.11

PATCH New Greg KH 1 participant 3 messages Mar 10, 2005 Driver core

lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 1/1 debugfs fixes for 2.6.11

Hi,

Here are two debugfs fixes. They have been in the -mm releases for a while.

Please pull from: bk://kernel.bkbits.net/gregkh/linux/2.6.11/debugfs

Individual patches will follow, sent to the linux-kernel list.

thanks,

greg k-h

 fs/debugfs/file.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

-----

Greg Kroah-Hartman:
o debugfs: fix bool built-in type
o debufs: make built in types add a \n to their output

author
#1 lore raw

PATCH 1/1 debufs: make built in types add a \n to their output

ChangeSet 1.2033, 2005/03/09 15:24:07-08:00, [email protected]

[PATCH] debufs: make built in types add a \n to their output

Thanks to Alessandro Rubini <[email protected]> for pointing this out.

 fs/debugfs/file.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
fs/debugfs/file.c +1 -1
diff -Nru a/fs/debugfs/file.c b/fs/debugfs/file.c
@@ -52,7 +52,7 @@
 	char buf[32];								\
 	type *val = file->private_data;						\
 										\
-	snprintf(buf, sizeof(buf), format, *val);				\
+	snprintf(buf, sizeof(buf), format "\n", *val);				\
 	return simple_read_from_buffer(user_buf, count, ppos, buf, strlen(buf));\
 }										\
 static ssize_t write_file_##type(struct file *file, const char __user *user_buf,\
author
#2 lore raw

PATCH 1/1 debugfs: fix bool built-in type.

ChangeSet 1.2034, 2005/03/09 15:24:27-08:00, [email protected]

[PATCH] debugfs: fix bool built-in type.

Thanks to Alessandro Rubini <[email protected]> for pointing this out.

 fs/debugfs/file.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
fs/debugfs/file.c +1 -1
diff -Nru a/fs/debugfs/file.c b/fs/debugfs/file.c
@@ -186,7 +186,7 @@
 	char buf[3];
 	u32 *val = file->private_data;
 	
-	if (val)
+	if (*val)
 		buf[0] = 'Y';
 	else
 		buf[0] = 'N';