Skip to contentSkip to conversation

u-boot patch: restore deleted OHCI copyrights

U-Boot-Users David Brownell 2 participants 2 messages Mar 11, 2005 – Mar 14, 2005

lore
Share & tools
lore
#0 lore raw

I happened to notice that someone deleted my copyright statements (and Roman's) from the OHCI drivers. Please remedy this ASAP, both in U-Boot and in the various similar non-merged patches. (I've seen the same done with the au1xxx OHCI code too...)

Also, remember never to do that again. The copying was egregious:
much of the code is line-for-line identical, and even the basic driver design (the hard stuff!) was unchanged. It is **NEVER OK TO DELETE COPYRIGHT DECLARATIONS** like that. NEVER. Grumph.

- Dave
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Diff
Type: text/x-diff
Size: 1509 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050310/eb78c298/attachment.diff

#1 lore raw

Dear Dave,

Quoted 5 lines · in message <[email protected]> you wrote:

I happened to notice that someone deleted my copyright statements (and Roman's) from the OHCI drivers. Please remedy this ASAP, both in U-Boot and in the various similar non-merged patches. (I've seen the same done with the au1xxx OHCI code too...)

Fixed in the current code. I will try to remember having an eye on this for the pending patches.

Quoted 4 lines

Also, remember never to do that again. The copying was egregious:
much of the code is line-for-line identical, and even the basic driver design (the hard stuff!) was unchanged. It is **NEVER OK TO DELETE COPYRIGHT DECLARATIONS** like that. NEVER. Grumph.

You are absolutely right. I apologize for missing this when reviewing the patches. Thanks for pointing out!

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Imagination is more important than knowledge.      -- Albert Einstein