Skip to contentSkip to conversation

msi build error on ia64

PATCH Andrew Morton 1 participant 1 message Mar 12, 2005 PCI

lore
Share & tools
lore
#0 lore raw

Doing a `make allmodconfig' with Linus's latest tree:

drivers/built-in.o(.text+0x10302): In function `msi_init':
drivers/pci/msi.c:373: undefined reference to pci_msi_quirk' drivers/built-in.o(.text+0x10320):drivers/pci/msi.c:373: undefined reference to pci_msi_quirk'

This is because drivers/pci/quirks.c:pci_msi_quirk is only defined if CONFIG_X86_IO_APIC, but msi_init() unconditionally uses it.

Is this fix appropriate?

drivers/pci/pci.h renamed from drivers/pci/pci.h~ia64-msi-build-fix +6 -1
@@ -64,8 +64,13 @@ extern void pci_remove_legacy_files(stru
 /* Lock for read/write access to pci device and bus lists */
 extern spinlock_t pci_bus_lock;
 
-extern int pcie_mch_quirk;
+#ifdef CONFIG_X86_IO_APIC
 extern int pci_msi_quirk;
+#else
+#define pci_msi_quirk 0
+#endif
+
+extern int pcie_mch_quirk;
 extern struct device_attribute pci_dev_attrs[];
 extern struct class_device_attribute class_device_attr_cpuaffinity;
 

_