Skip to contentSkip to conversation

2.6.11 does not handle IRQ #0 on IXP4xx ARM platforms

PATCH In review Juan M. de la Torre 2 participants 2 messages Mar 12, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 2.6.11 does not handle IRQ #0 on IXP4xx ARM platforms

The original get_irqnr_and_bse macro leave Z flag set when the IRQ being handled is #0, but the correct behaviour is to clear the flag when there is at least one IRQ to handle.

PS: Please CC me in the reply because i'm not subscribed to the list

Signature · 1 line
/jm
include/asm-arm/arch-ixp4xx/entry-macro.S +1 -1
@@ -18,7 +18,7 @@
 		beq	1001f
 		clz     \irqnr, \irqstat
 		mov     \base, #31
-		subs    \irqnr, \base, \irqnr
+		sub     \irqnr, \base, \irqnr
 
 1001:
 		/*
#1 lore raw
Quoted 6 lines · Juan M. de la Torre

The original get_irqnr_and_bse macro leave Z flag set when the IRQ being handled is #0, but the correct behaviour is to clear the flag when there is at least one IRQ to handle.

PS: Please CC me in the reply because i'm not subscribed to the list

Best talk to the linux-arm-kernel list, which can be found on http://www.arm.linux.org.uk/

There is also an linux-arm patch tracking system there where you can submit fixes like that for the Linux/ARM community to check.

Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'