Skip to contentSkip to conversation

compiler warning

PATCH In review Paul Brook 1 participant 2 messages Mar 20, 2005

lore
Share & tools
lore

Paul Brook

author
#0 lore raw

PATCH 1/1 compiler warning

The patch below fixes the following compiler warning:

cpu-exec.c:763: warning: control reaches end of non-void function

Paul

Index: cpu-exec.c
===================================================================
RCS file: /cvsroot/qemu/qemu/cpu-exec.c,v
retrieving revision 1.51

cpu-exec.c 20 Mar 2005 18:39:09 -0000 renamed from cpu-exec.c 22 Feb 2005 19:27:14 -0000 1.51 +2 -0
diff -u -p -r1.51 cpu-exec.c
@@ -786,6 +791,8 @@ static inline int handle_cpu_signal(unsi
        do it (XXX: use sigsetjmp) */
     sigprocmask(SIG_SETMASK, old_set, NULL);
     cpu_loop_exit();
+    /* never comes here */
+    return 1;
 }
 #elif defined(TARGET_SPARC)
 static inline int handle_cpu_signal(unsigned long pc, unsigned long address,
author
#1 lore raw
Quoted 3 lines · Paul Brook

The patch below fixes the following compiler warning:

cpu-exec.c:763: warning: control reaches end of non-void function

Updated version also fixes a similar problem with the SPARC target.

Paul

Index: cpu-exec.c
===================================================================
RCS file: /cvsroot/qemu/qemu/cpu-exec.c,v
retrieving revision 1.51

cpu-exec.c 20 Mar 2005 20:03:21 -0000 renamed from cpu-exec.c 22 Feb 2005 19:27:14 -0000 1.51 +4 -0
diff -u -p -r1.51 cpu-exec.c
@@ -786,6 +791,8 @@ static inline int handle_cpu_signal(unsi
        do it (XXX: use sigsetjmp) */
     sigprocmask(SIG_SETMASK, old_set, NULL);
     cpu_loop_exit();
+    /* never comes here */
+    return 1;
 }
 #elif defined(TARGET_SPARC)
 static inline int handle_cpu_signal(unsigned long pc, unsigned long address,

@@ -822,6 +829,8 @@ static inline int handle_cpu_signal(unsi
        do it (XXX: use sigsetjmp) */
     sigprocmask(SIG_SETMASK, old_set, NULL);
     cpu_loop_exit();
+    /* never comes here */
+    return 1;
 }
 #elif defined (TARGET_PPC)
 static inline int handle_cpu_signal(unsigned long pc, unsigned long address,