Skip to contentSkip to conversation

drivers/scsi/osst.c: remove unused code

PATCH In review Adrian Bunk 2 participants 2 messages Mar 22, 2005 – Mar 23, 2005 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/scsi/osst.c: remove unused code

Thanks to both the Coverity checker and GNU gcc, it was found that this variable is completely unused.

drivers/scsi/osst.c renamed from drivers/scsi/osst.c.old +0 -3
@@ -4770,9 +4770,6 @@ static int os_scsi_tape_close(struct ino
 {
 	int		      result = 0;
 	struct osst_tape    * STp    = filp->private_data;
-	struct scsi_request * SRpnt  = NULL;
-
-	if (SRpnt) scsi_release_request(SRpnt);
 
 	if (STp->door_locked == ST_LOCKED_AUTO)
 		do_door_lock(STp, 0);
#1 lore raw
Quoted 4 lines · Adrian Bunk

Thanks to both the Coverity checker and GNU gcc, it was found that this variable is completely unused.

And it is so obvious when your attention is drawn to it. The code that did use it moved to os_scsi_tape_flush() recently.

James, could you make this change in BK too, please?

Quoted 13 lines
drivers/scsi/osst.c renamed from drivers/scsi/osst.c.old +0 -3
@@ -4770,9 +4770,6 @@ static int os_scsi_tape_close(struct ino
 {
 	int		      result = 0;
 	struct osst_tape    * STp    = filp->private_data;
-	struct scsi_request * SRpnt  = NULL;
-
-	if (SRpnt) scsi_release_request(SRpnt);
 
 	if (STp->door_locked == ST_LOCKED_AUTO)
 		do_door_lock(STp, 0);