Skip to contentSkip to conversation

drivers/acpi/scan.c: inconsequent NULL handling

DISCUSSION Adrian Bunk 1 participant 1 message Mar 24, 2005 ACPI

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

The Coverity checker found the following:

<-- snip -->

static int
acpi_bus_match (
struct acpi_device *device,
struct acpi_driver *driver)

{
        if (driver && driver->ops.match)
                return driver->ops.match(device, driver);
        return acpi_match_ids(device, driver->ids);
}

<-- snip -->

Either driver can be NULL, in which case the driver->ids is a possible NULL pointer reference, or it can't, in which case the check whether it's NULL is superfluous.

cu
Adrian

Signature · 12 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click