Skip to contentSkip to conversation

I2C: Delete useless instruction in it87

PATCH New Jean Delvare 2 participants 2 messages May 19, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 I2C: Delete useless instruction in it87

Hi Greg,

The IT8705F doesn't support VID, so it's quite pointless to give a value to it (and an arbitrary one at that). I think that this instruction was there for compatibility reasons some times ago, but the reasons went away while the instruction was left in place. We can safely delete it now.

Thanks to Rudolf Marek for testing the patch (you never know).

Please apply,
thanks.

drivers/i2c/chips/it87.c renamed from drivers/i2c/chips/it87.c.orig +0 -3
@@ -1122,9 +1122,6 @@
 			    it87_read_value(client, IT87_REG_TEMP_LOW(i));
 		}
 
-		/* The 8705 does not have VID capability */
-		data->vid = 0x1f;
-
 		i = it87_read_value(client, IT87_REG_FAN_DIV);
 		data->fan_div[0] = i & 0x07;
 		data->fan_div[1] = (i >> 3) & 0x07;
Signature · 1 line
Jean Delvare
Applied
#1 lore raw

PATCH 1/1 I2C: Delete useless instruction in it87

Quoted 8 lines · Jean Delvare

Hi Greg,

The IT8705F doesn't support VID, so it's quite pointless to give a value to it (and an arbitrary one at that). I think that this instruction was there for compatibility reasons some times ago, but the reasons went away while the instruction was left in place. We can safely delete it now.

Quoted 4 lines

Thanks to Rudolf Marek for testing the patch (you never know).

Please apply,
thanks.

Applied, thanks.

greg k-h