Skip to contentSkip to conversation

Fix acl Oops

PATCH In review [email protected] 1 participant 1 message Apr 12, 2005 ext2 file system

lore
Share & tools
lore
#0 lore raw

PATCH 9/198 Fix acl Oops

From: Andreas Gruenbacher <[email protected]>

ext[23]_get_acl will return an error when reading the attribute fails or out-of-memory occurs. Catch this case.

---

 25-akpm/fs/ext2/acl.c |    2 ++
 25-akpm/fs/ext3/acl.c |    2 ++
 2 files changed, 4 insertions(+)
fs/ext2/acl.c renamed from fs/ext2/acl.c~fix-acl-oops +2 -0
diff -puN fs/ext2/acl.c~fix-acl-oops fs/ext2/acl.c
@@ -283,6 +283,8 @@ ext2_check_acl(struct inode *inode, int 
 {
 	struct posix_acl *acl = ext2_get_acl(inode, ACL_TYPE_ACCESS);
 
+	if (IS_ERR(acl))
+		return PTR_ERR(acl);
 	if (acl) {
 		int error = posix_acl_permission(inode, acl, mask);
 		posix_acl_release(acl);
fs/ext3/acl.c renamed from fs/ext3/acl.c~fix-acl-oops +2 -0
diff -puN fs/ext3/acl.c~fix-acl-oops fs/ext3/acl.c
@@ -286,6 +286,8 @@ ext3_check_acl(struct inode *inode, int 
 {
 	struct posix_acl *acl = ext3_get_acl(inode, ACL_TYPE_ACCESS);
 
+	if (IS_ERR(acl))
+		return PTR_ERR(acl);
 	if (acl) {
 		int error = posix_acl_permission(inode, acl, mask);
 		posix_acl_release(acl);

_