Skip to contentSkip to conversation

drivers/ieee1394/ieee1394_transactions.c: possible cleanups

PATCH Applied Adrian Bunk 2 participants 2 messages Apr 19, 2005 – Apr 21, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/ieee1394/ieee1394_transactions.c: possible cleanups

This patch contains the following possible cleanups:
- #if 0 the following unused global functions:
- hpsb_lock
- hpsb_send_gasp
- ieee1394_transactions.h: remove the stale hpsb_lock64 prototype

---

 drivers/ieee1394/ieee1394_transactions.c |    3 +++
 drivers/ieee1394/ieee1394_transactions.h |    7 -------
 2 files changed, 3 insertions(+), 7 deletions(-)
drivers/ieee1394/ieee1394_transactions.h renamed from drivers/ieee1394/ieee1394_transactions.h.old +0 -7
@@ -53,12 +53,5 @@
 	      u64 addr, quadlet_t *buffer, size_t length);
 int hpsb_write(struct hpsb_host *host, nodeid_t node, unsigned int generation,
 	       u64 addr, quadlet_t *buffer, size_t length);
-int hpsb_lock(struct hpsb_host *host, nodeid_t node, unsigned int generation,
-	      u64 addr, int extcode, quadlet_t *data, quadlet_t arg);
-int hpsb_lock64(struct hpsb_host *host, nodeid_t node, unsigned int generation,
-		u64 addr, int extcode, octlet_t *data, octlet_t arg);
-int hpsb_send_gasp(struct hpsb_host *host, int channel, unsigned int generation,
-                   quadlet_t *buffer, size_t length, u32 specifier_id,
-                   unsigned int version);
 
 #endif /* _IEEE1394_TRANSACTIONS_H */
drivers/ieee1394/ieee1394_transactions.c renamed from drivers/ieee1394/ieee1394_transactions.c.old +3 -0
@@ -535,6 +535,7 @@
         return retval;
 }
 
+#if 0
 
 int hpsb_lock(struct hpsb_host *host, nodeid_t node, unsigned int generation,
 	      u64 addr, int extcode, quadlet_t *data, quadlet_t arg)
@@ -599,3 +600,5 @@
 
 	return retval;
 }
+
+#endif  /*  0  */
#1 lore raw
Quoted 5 lines · Adrian Bunk

This patch contains the following possible cleanups:
- #if 0 the following unused global functions:
- hpsb_lock
- hpsb_send_gasp
- ieee1394_transactions.h: remove the stale hpsb_lock64 prototype

I also removed the EXPORT_SYMBOL of hpsb_lock, since we're not (yet?) accepting your earlier patch.

Applied to our SVN and queued for 2.6.13. Thanks.

Jody

Quoted 50 lines

---

 drivers/ieee1394/ieee1394_transactions.c |    3 +++
 drivers/ieee1394/ieee1394_transactions.h |    7 -------
 2 files changed, 3 insertions(+), 7 deletions(-)
drivers/ieee1394/ieee1394_transactions.h renamed from drivers/ieee1394/ieee1394_transactions.h.old +0 -7
@@ -53,12 +53,5 @@
 	      u64 addr, quadlet_t *buffer, size_t length);
 int hpsb_write(struct hpsb_host *host, nodeid_t node, unsigned int generation,
 	       u64 addr, quadlet_t *buffer, size_t length);
-int hpsb_lock(struct hpsb_host *host, nodeid_t node, unsigned int generation,
-	      u64 addr, int extcode, quadlet_t *data, quadlet_t arg);
-int hpsb_lock64(struct hpsb_host *host, nodeid_t node, unsigned int generation,
-		u64 addr, int extcode, octlet_t *data, octlet_t arg);
-int hpsb_send_gasp(struct hpsb_host *host, int channel, unsigned int generation,
-                   quadlet_t *buffer, size_t length, u32 specifier_id,
-                   unsigned int version);
 
 #endif /* _IEEE1394_TRANSACTIONS_H */
drivers/ieee1394/ieee1394_transactions.c renamed from drivers/ieee1394/ieee1394_transactions.c.old +3 -1
@@ -535,6 +535,7 @@
         return retval;
 }
 
+#if 0
 
 int hpsb_lock(struct hpsb_host *host, nodeid_t node, unsigned int generation,
 	      u64 addr, int extcode, quadlet_t *data, quadlet_t arg)
@@ -599,3 +600,5 @@
 
 	return retval;
 }
+
+#endif  /*  0  */
 
 
 
-------------------------------------------------------

This SF.Net email is sponsored by: New Crystal Reports XI. Version 11 adds new functionality designed to reduce time involved in creating, integrating, and deploying reporting solutions. Free runtime info, new features, or free trial, at: http://www.businessobjects.com/devxi/728
_______________________________________________
mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/linux1394-devel