Skip to contentSkip to conversation

hfsplus: add an option to force r/w mount

PATCH Roman Zippel 2 participants 3 messages Apr 20, 2005 – Apr 21, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi,

Quoted 2 lines · Colin Leroy

for some reason yet unknown, fsck.hfsplus doesn't correctly set the HFSPLUS_VOL_UNMNT flag here.

If fsck doesn't mark it clean, there must be a reason and that also means you shouldn't mount it writable.

bye, Roman

#2 lore raw

On 20 Apr 2005 at 22h04, Roman Zippel wrote:

Hi,

Quoted 9 lines

Hi,

Quoted 2 lines · Colin Leroy

for some reason yet unknown, fsck.hfsplus doesn't correctly set the HFSPLUS_VOL_UNMNT flag here.

If fsck doesn't mark it clean, there must be a reason and that also means you shouldn't mount it writable.

that's what i thought too, but adding debug printf() to it, i see that it marks it clean at the end. However that doesn't seem to effectively land on the disc. imho the patch has an interest anyway...

Signature · 1 line
Colin
#3 lore raw
In reply to Roman Zippel

On 20 Apr 2005 at 22h04, Roman Zippel wrote:

Hi,

Quoted 4 lines
Quoted 2 lines

for some reason yet unknown, fsck.hfsplus doesn't correctly set the HFSPLUS_VOL_UNMNT flag here.

If fsck doesn't mark it clean, there must be a reason

By the way, the reason is that this stupid utility opens the device read-only (hence it can't fix nothing).

from hfsplusutils/libhfsp/src/fscheck.c:

    result = fscheck_volume_open(&vol, device, HFSP_MODE_RDONLY);

Seeing that it has been untouched since 2002, I guess it'll be hard to get it fixed. Or maybe it's just me being idiot and I should use another fsck ?

Signature · 1 line
Colin