Skip to contentSkip to conversation

kill old EH constants

PATCH Geert Uytterhoeven 3 participants 3 messages Apr 21, 2005 1 message not in the archive SCSI

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 5 lines · Linux Kernel Mailing List

tree 932c6f9689fd08a7a9d689cfbec8682ccde8175d
parent 84011ae88da62a20b3ae7b48e2ae3b1ef0fc810a
author <[email protected]> Mon, 11 Apr 2005 08:19:25 -0500 committer James Bottomley <jejb@titanic> Sun, 17 Apr 2005 06:14:52 -0500

Quoted 8 lines

[PATCH] kill old EH constants

Fix up two drivers that incorrectly were using the old return values for their new-style EH methods and kill off scsi_obsolete.h that defined the constants. The initio driver has all these constansts defined locally and uses them internally, I'll fix that up some time later.

sun3_NCR5380.c still uses the following:

- SCSI_ABORT_SUCCESS
- SCSI_ABORT_ERROR
- SCSI_ABORT_SNOOZE
- SCSI_ABORT_BUSY
- SCSI_ABORT_NOT_RUNNING
- SCSI_RESET_SUCCESS
- SCSI_RESET_BUS_RESET

causing the driver to fail to build in 2.6.12-rc3. What should I replace them by?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw
Quoted 10 lines · Geert Uytterhoeven

sun3_NCR5380.c still uses the following:

- SCSI_ABORT_SUCCESS
- SCSI_ABORT_ERROR
- SCSI_ABORT_SNOOZE
- SCSI_ABORT_BUSY
- SCSI_ABORT_NOT_RUNNING
- SCSI_RESET_SUCCESS
- SCSI_RESET_BUS_RESET

Quoted 2 lines

causing the driver to fail to build in 2.6.12-rc3. What should I replace them by?

You must replace NCR5380_abort and NCR5380_bus_reset with real new-style EH routines. I'd suggest copying them from NCR5380.c or even better scrapping sun3_NCR5380.c in favour of that one completely.

#3 lore raw
Quoted 11 lines · Christoph Hellwig
Quoted 10 lines · Geert Uytterhoeven

sun3_NCR5380.c still uses the following:

- SCSI_ABORT_SUCCESS
- SCSI_ABORT_ERROR
- SCSI_ABORT_SNOOZE
- SCSI_ABORT_BUSY
- SCSI_ABORT_NOT_RUNNING
- SCSI_RESET_SUCCESS
- SCSI_RESET_BUS_RESET

Quoted 6 lines
Quoted 2 lines

causing the driver to fail to build in 2.6.12-rc3. What should I replace them by?

You must replace NCR5380_abort and NCR5380_bus_reset with real new-style EH routines. I'd suggest copying them from NCR5380.c or even better scrapping sun3_NCR5380.c in favour of that one completely.

Trust me, there's reasons we don't use NCR5380.c.... (primarily, this has to due with the order of operations necessary to keep the DMA controller happpy, which required changing the flow of several functions (admittedly, I haven't looked into this again since the "new-style" driver change)).

That being said, it seems the first option needs done. I suppose I'll add fixing those two routines to my long list of backlogged sun3 stuff which needs doing.

-- Sam