Skip to contentSkip to conversation

drivers/scsi/FlashPoint.c: cleanups

PATCH In review Adrian Bunk 3 participants 3 messages Apr 23, 2005 – Apr 25, 2005 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/scsi/FlashPoint.c: cleanups

This patch contains cleanups including the following:
- remove #ifdef'ed code for other OS's
- remove other unused code
- make needlessly global code static

---

Due to it's size, the patch is attached gzip'ed.

 drivers/scsi/FlashPoint.c | 5872 ++++++--------------------------------
 1 files changed, 973 insertions(+), 4899 deletions(-)
#1 lore raw
Quoted 4 lines · Adrian Bunk

This patch contains cleanups including the following:
- remove #ifdef'ed code for other OS's
- remove other unused code
- make needlessly global code static

I'd rather not touch this file currently. It's glued toghether from lots of separate files in the original code. Before doing cleanups I'd rather split it into all these files first as the file is a huge mess as-is.

#2 lore raw
In reply to Adrian Bunk
Quoted 4 lines

This patch contains cleanups including the following:
- remove #ifdef'ed code for other OS's
- remove other unused code
- make needlessly global code static

FYI, (1) and part of your (2) are already sitting in -kj (splitted).

http://coderock.org/kj/2.6.12-rc3-kj/split/defines-drivers_scsi_FlashPoint.patch
http://coderock.org/kj/2.6.12-rc3-kj/split/comments-drivers_scsi_FlashPoint

And I hope cleaning FlashPoint mess will be splitted.