lpfc: hgp/pgp cleanups
Subsystems (2)
PATCH 1/1 lpfc: hgp/pgp cleanups
- rename PGP/HPH to lpfc_pgp/lpfc_hgp
- use __le32 types for the members to start fixing sparse -Wbitwise issues
- remove lpfc_sli.MBhostaddr, we can always use the pointer from SLI2_DESC directly
drivers/scsi/lpfc/lpfc_hw.h +10 -10
@@ -2214,20 +2214,20 @@* SLI-2 specific structures */ -typedef struct { -uint32_t cmdPutInx; -uint32_t rspGetInx; -}HGP ; +struct lpfc_hgp { +__le32 cmdPutInx; +__le32 rspGetInx; +}; -typedef struct { -uint32_t cmdGetInx; -uint32_t rspPutInx; -}PGP ; +struct lpfc_pgp { +__le32 cmdGetInx; +__le32 rspPutInx; +};typedef struct _SLI2_DESC { -HGP host[MAX_RINGS ]; +struct lpfc_hgp host[MAX_RINGS ];uint32_t unused1[16 ]; -PGP port[MAX_RINGS ]; +struct lpfc_pgp port[MAX_RINGS ]; }SLI2_DESC ; typedef union {
===== drivers/scsi/lpfc/lpfc_mbox.c 1.1 vs edited =====
drivers/scsi/lpfc/lpfc_mbox.c +3 -4
@@ -422,7 +422,6 @@uint32_t iocbCnt;int i; - psli->MBhostaddr = (uint32_t *)&phba->slim2p->mbx; pcbp->maxRing = (psli->num_rings -1 ); iocbCnt =0 ;
@@ -528,7 +527,7 @@dma_addr_t pdma_addr;uint32_t bar_low, bar_high;size_t offset; -HGP hgp; +struct lpfc_hgp hgp;void __iomem *to_slim;memset (pmb,0 ,sizeof (LPFC_MBOXQ_t));
@@ -584,9 +583,9 @@else phba->slim2p->pcb.hgpAddrHigh =0 ;/* write HGP data to SLIM at the required longword offset */ -memset (&hgp,0 ,sizeof (HGP )); +memset (&hgp,0 ,sizeof (struct lpfc_hgp )); to_slim = phba->MBslimaddr + (SLIMOFF *sizeof (uint32_t )); -lpfc_memcpy_to_slim (to_slim, &hgp,sizeof (HGP )); +lpfc_memcpy_to_slim (to_slim, &hgp,sizeof (struct lpfc_hgp ));/* Setup Port Group ring pointer */ offset = (uint8_t *)&phba->slim2p->mbx.us.s2.port -
===== drivers/scsi/lpfc/lpfc_sli.c 1.1 vs edited =====
drivers/scsi/lpfc/lpfc_sli.c +13 -32
125 lines not on this page · raw message