porting lockless mce from x86_64 to i386
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 2 lines · Luming
Forward a patch :
Some comments:
The asmlinkage on x86-64 is not really needed. You can remove the ifdef. fastcall is fine, although it is a nop.
The u64 tsc[NR CPUS] on the stack is a stack overflow with big NR_CPUS. I have
a patch locally here to fix it, but you could just apply it anyways when you move the code. Fix is to use kmalloc here.
-Andi
Quoted 7 lines · Andi Kleen
Quoted 2 lines · Luming
Forward a patch :
Some comments:
Quoted 8 lines
The asmlinkage on x86-64 is not really needed. You can remove the ifdef. fastcall is fine, although it is a nop.
The u64 tsc[NR CPUS] on the stack is a stack overflow with big
NR_CPUS. I have
a patch locally here to fix it, but you could just apply it anyways when you move the code. Fix is to use kmalloc here.
OK, thanks. Luming, could you please reissue the second patch, including the above fixes as well as the two warning fixes which we discussed?
Quoted 11 lines · Andrew Morton
Quoted 10 lines · Andi Kleen
Quoted 2 lines · Luming
Forward a patch :
Some comments:
The asmlinkage on x86-64 is not really needed. You can remove the ifdef. fastcall is fine, although it is a nop.
Quoted 8 lines
Quoted 5 lines
The u64 tsc[NR CPUS] on the stack is a stack overflow with big
NR_CPUS. I have
a patch locally here to fix it, but you could just apply it anyways when you move the code. Fix is to use kmalloc here.OK, thanks. Luming, could you please reissue the second patch, including the above fixes as well as the two warning fixes which we discussed?
Another comment:
If Luming would not move the mce.c file from x86-64 to i386 then his patch would be only 1/4 as big. I dont know why he does this anyways, it seems completely pointless.
-Andi