Skip to contentSkip to conversation

Thumb bugfixes

PATCH New Paul Brook 1 participant 1 message Apr 26, 2005

lore
Share & tools
lore

Paul Brook

author
#0 lore raw

PATCH 1/1 Thumb bugfixes

The attached patch fixes several bugs in the arm thumb emulation.

Paul

Index: target-arm/op.c
===================================================================
RCS file: /cvsroot/qemu/qemu/target-arm/op.c,v
retrieving revision 1.12

op.c +2 -1
diff -u -p -r1.12 op.c
@@ -824,12 +824,13 @@ void OPPROTO op_shrl_T0_im_thumb(void)
 
     shift = PARAM1;
     if (shift == 0) {
-	env->CF = 0;
+	env->CF = ((uint32_t)shift) >> 31;
 	T0 = 0;
     } else {
 	env->CF = (T0 >> (shift - 1)) & 1;
 	T0 = T0 >> shift;
     }
+    env->NZF = T0;
     FORCE_RET();
 }
 

Index: target-arm/translate.c
===================================================================
RCS file: /cvsroot/qemu/qemu/target-arm/translate.c,v retrieving revision 1.23

translate.c +53 -33

223 lines not on this page · raw message