Skip to contentSkip to conversation

preserve ARCH and CROSS_COMPILE in the build directory generated Makefile

PATCH In review Pavel Pisa 4 participants 5 messages Apr 29, 2005 Kbuild

lore
Share & tools
lore

Pavel Pisa

author
#0 lore raw

PATCH 1/1 preserve ARCH and CROSS_COMPILE in the build directory generated Makefile

This patch ensures, that architecture and target cross-tools prefix is preserved in the Makefile generated in the build directory for out of source tree kernel compilation. This prevents accidental screwing of configuration and builds for the case, that make without full architecture specific options is invoked in the build directory. It is secure use accustomed "make", "make xconfig", etc. without fear and special care now.

scripts/mkmakefile +6 -0
Index: linux-2.6.11.5/scripts/mkmakefile
===================================================================
@@ -29,3 +29,9 @@ all:
 
 EOF
 
+if [ -n "${ARCH}" ] ; then
+	echo "ARCH ?= ${ARCH}"
+fi
+if [ -n "${CROSS_COMPILE}" ] ; then
+	echo "CROSS_COMPILE ?= ${CROSS_COMPILE}"
+fi
#1 lore raw
Quoted 7 lines · Pavel Pisa

This patch ensures, that architecture and target cross-tools prefix is preserved in the Makefile generated in the build directory for out of source tree kernel compilation. This prevents accidental screwing of configuration and builds for the case, that make without full architecture specific options is invoked in the build directory. It is secure use accustomed "make", "make xconfig", etc. without fear and special care now.

Hi Pavel.
I will not apply this path because it introduce a difference when building usign a separate output direcory compared to an in-tree build.

I have briefly looked into a solution where I could add this information in .config but was sidetracked by other stuff so I newer got it working.

The build system for the kernel needs to be as predictable as possible and introducing functionality that is only valid when using a separate output directory does not help here.

Sam

#2 lore raw
Quoted 13 lines · Sam Ravnborg
Quoted 7 lines · Pavel Pisa

This patch ensures, that architecture and target cross-tools prefix is preserved in the Makefile generated in the build directory for out of source tree kernel compilation. This prevents accidental screwing of configuration and builds for the case, that make without full architecture specific options is invoked in the build directory. It is secure use accustomed "make", "make xconfig", etc. without fear and special care now.

Hi Pavel.
I will not apply this path because it introduce a difference when building usign a separate output direcory compared to an in-tree build.

Quoted 6 lines

I have briefly looked into a solution where I could add this information in .config but was sidetracked by other stuff so I newer got it working.

The build system for the kernel needs to be as predictable as possible and introducing functionality that is only valid when using a separate output directory does not help here.

Without it, folk will then do (and this is taken from someone elses example):

cd /usr/src
tar -xjf /path/to/linux-2.6.x.tar.bz
cd linux-2.6.x
mkdir -p _build/arm
cd _build/arm
cat >GNUmakefile <<EOF
VERSION = 2
PATCHLEVEL = 6

KERNELSRC := /usr/src/linux-2.6.x
KERNELOUTPUT := /usr/src/linux-2.6.x/_build/arm

MAKEFLAGS += --no-print-directory

ARCH            = arm
#CROSS_COMPILE  = arm-unknown-linux-gnu-
CROSS_COMPILE   = arm-linux-

all:

        $(MAKE) ARCH=$(ARCH) CROSS_COMPILE=$(CROSS_COMPILE) -C $(KERNELSRC) O=$(KERNELOUTPUT)

%::

        $(MAKE) ARCH=$(ARCH) CROSS_COMPILE=$(CROSS_COMPILE) -C $(KERNELSRC) O=$(KERNELOUTPUT) $@

EOF
make xconfig
make

which I think you'll agree is far worse.

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
author
#3 lore raw
Quoted 17 lines · Russell King
Quoted 16 lines · Sam Ravnborg
Quoted 7 lines · Pavel Pisa

This patch ensures, that architecture and target cross-tools prefix is preserved in the Makefile generated in the build directory for out of source tree kernel compilation. This prevents accidental screwing of configuration and builds for the case, that make without full architecture specific options is invoked in the build directory. It is secure use accustomed "make", "make xconfig", etc. without fear and special care now.

Hi Pavel.
I will not apply this path because it introduce a difference when building usign a separate output direcory compared to an in-tree build.

I have briefly looked into a solution where I could add this information in .config but was sidetracked by other stuff so I newer got it working.

Quoted 8 lines
Quoted 3 lines

The build system for the kernel needs to be as predictable as possible and introducing functionality that is only valid when using a separate output directory does not help here.

Without it, folk will then do (and this is taken from someone elses example):

which I think you'll agree is far worse.

Hello Sam and Russell,

thanks, Russell, for defending me through pointing me as an bad example :-) .

Excuse me for that outcome of my two neurons scratch, but I have decided to send my ideas for discussion and possibly to help others. The decision, what is good thing to do now and what should be left in air for future better decisions
is on you. Thanks for energy put into reading and thinking about my ideas.

I provide another idea, which is not dependant on out of source tree build

ifeq ("$(origin ARCH)", "command line")
prepare1: archpreserve

archpreserve:

	echo "ARCH ?= $(ARCH)" >$(objtree)/.archconfig
	echo "CROSS_COMPILE ?= $(CROSS_COMPILE)" >>$(objtree)/.archconfig

else
-include $(objtree)/.archconfig
endif

With wish of sunny weekend

Pavel

#4 lore raw
In reply to Sam Ravnborg
Quoted 13 lines · Sam Ravnborg
Quoted 7 lines · Pavel Pisa

This patch ensures, that architecture and target cross-tools prefix is preserved in the Makefile generated in the build directory for out of source tree kernel compilation. This prevents accidental screwing of configuration and builds for the case, that make without full architecture specific options is invoked in the build directory. It is secure use accustomed "make", "make xconfig", etc. without fear and special care now.

Hi Pavel.
I will not apply this path because it introduce a difference when building usign a separate output direcory compared to an in-tree build.

Quoted 6 lines

I have briefly looked into a solution where I could add this information in .config but was sidetracked by other stuff so I newer got it working.

The build system for the kernel needs to be as predictable as possible and introducing functionality that is only valid when using a separate output directory does not help here.

You could drop it into a file unrelated to .config or Makefile; that might be simpler.

Signature · 2 lines
Daniel Jacobowitz
CodeSourcery, LLC