Skip to contentSkip to conversation

SquashFS cleanup: container_of over list_entry

DISCUSSION Blaisorblade 1 participant 1 message May 2, 2005

lore
Share & tools
lore
#0 lore raw

Looking at fs/squashfs/inode.c (in the release used on Gentoo) I've found this code:

static inline struct squashfs_inode_info *SQUASHFS_I(struct inode *inode)

{
        return list_entry(inode, struct squashfs_inode_info, vfs_inode);
}
Quoted 1 line

From the cosmetical point of view, shouldn't that be:

        return container_of(inode, struct squashfs_inode_info, vfs_inode);

? The implementation is the same, but the second is clearer (adding a definition in the header would be OK if you need that it works on 2.4, if that's the reason).

My 2 cents.

Regards.

Signature · 4 lines
Paolo Giarrusso, aka Blaisorblade
Skype user "PaoloGiarrusso"
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade