Skip to contentSkip to conversation

Do not enforce unique IO_APIC_ID for Xeon processors in EM64T mode (x86_64)

PATCH In review [email protected] 2 participants 2 messages May 8, 2005

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 Do not enforce unique IO_APIC_ID for Xeon processors in EM64T mode (x86_64)

I revised the patch and it came out simpler (and much smaller) this time :) Please consider the following version:

<-Snip->

This patch disables unique IO_APIC_ID check for xAPIC systems running in EM64T mode. Xeon-based ES7000s panic failing this unnecessary check. IO_APIC_IDs only need to be unique in case of serial APIC bus. xAPIC systems deliver interrupts over the system bus.

Signed-off by: Natalie Protasevich <[email protected]>

---

arch/x86_64/kernel/io_apic.c renamed from arch/x86_64/kernel/io_apic.c~no-ioapic-check-x86_64-2 +7 -3
diff -puN arch/x86_64/kernel/io_apic.c~no-ioapic-check-x86_64-2 arch/x86_64/kernel/io_apic.c
@@ -1867,12 +1867,16 @@ int __init io_apic_get_unique_id (int io
 	int i = 0;
 
 	/*
+	 * xAPIC systems take advantage of APIC system bus architecture.
+	 */
+	
+	 if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)
+		return apic_id;
+	
+	/*
 	 * The P4 platform supports up to 256 APIC IDs on two separate APIC 
 	 * buses (one for LAPICs, one for IOAPICs), where predecessors only 
 	 * supports up to 16 on one shared APIC bus.
-	 * 
-	 * TBD: Expand LAPIC/IOAPIC support on P4-class systems to take full
-	 *      advantage of new APIC bus architecture.
 	 */
 
 	if (physids_empty(apic_id_map))

_

#1 lore raw

arch/x86_64/kernel/io_apic.c int __init io_apic_get_unique_id (int io · line 1875

Quoted 13 lines · On Fri, 6 May 2005 [email protected] wrote:

diff -puN arch/x86_64/kernel/io_apic.c~no-ioapic-check-x86_64-2 arch/x86_64/kernel/io_apic.c

arch/x86_64/kernel/io_apic.c renamed from arch/x86_64/kernel/io_apic.c~no-ioapic-check-x86_64-2 +6 -0
@@ -1867,12 +1867,16 @@ int __init io_apic_get_unique_id (int io
 	int i = 0;
 
 	/*
+	 * xAPIC systems take advantage of APIC system bus architecture.
+	 */
+	
+	 if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL)
+		return apic_id;
+

Shouldn't this be for both em64t and amd64?