Skip to contentSkip to conversation

1.2.6 released. No more queue littering ...

DISCUSSION Mads Martin Joergensen 2 participants 4 messages May 8, 2005 – May 9, 2005

lore
Share & tools
lore
#0 lore raw

Hey people,

So ... as usual Andrea Barisani have found a couple of bugs, which we've fixed. This time the most annoying one was mlmmj littering files in LISTDIR/queue/, in case of odd mails that were to be ignored. So after you upgraded to 1.2.6 you should clean up your queue directories for old crap--if any.

There's also a couple of nice patches from Jakob Hirsch, so now mlmmj will tell you if you're trying to subscribe an already subscribed address or trying to unsub without being subbed.

The ChangeLog has it as usual:

1.2.6
o If prefix but no Subject: header is present, add one (Jakob Hirsch)
o Add notification mail when subbed people try to sub (Jakob Hirsch)
o Install SIGTERM handler in mlmmj-send to allow it to shut down gracefully
o Also remove mails when it's a bounce from a person not subbed
o Introduce read() wrapper (Stevens)
o Bouncing confirmation mails of sub or unsub should be cleaned from the queue as well
o Normally mails which doesn't have exactly one From: emailaddress are discarded but certain ISPs have bounce mails with no From: header, forcing us to allow bounce mails with no From: to make sure they're caught
o In case of a succesful DSN parse, we werent deleting the mail, and thus littering the queue
o When sending moderated mails, rename them so that they wont be moderated again while sending

Signature · 4 lines
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.
#1 lore raw
Quoted 1 line · Mads Martin Joergensen

o If prefix but no Subject: header is present, add one (Jakob Hirsch)

There's a bug here. In case we meet a subject already we forget to clear the flag. This patch should fix it, so that no 2 subjects are present:

do_all_the_voodo_here.c 9 May 2005 07:13:51 -0000 renamed from do_all_the_voodo_here.c 8 May 2005 16:18:02 -0000 1.24 +1 -0
@@ -142,6 +142,7 @@
                /* Add Subject: prefix if wanted */
                if(prefix) {
                        if(strncasecmp(hdrline, "Subject:", 8) = 0) {
+                               subject_present = 1;
                                unqp = cleanquotedp(hdrline + 8);
                                if(strstr(hdrline + 8, prefix) = NULL &&
                                   strstr(unqp, prefix) = NULL) {
Signature · 4 lines
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.
#2 lore raw
In reply to Mads Martin Joergensen
Quoted 5 lines · Mads Martin Joergensen
Quoted 1 line

o If prefix but no Subject: header is present, add one (Jakob Hirsch)

There's a bug here. In case we meet a subject already we forget to clear the flag. This patch should fix it, so that no 2 subjects are present:

+ subject_present = 1;

It's there (a few lines below), but will only be done if the subject contains the prefix, which is obiously wrong.
sorry for that.

the extra setting of subject_present doesn't hurt, but for clarity, it's better to remove it:

do_all_the_voodo_here.c 2005-05-09 14:41:41 +0200 renamed from do_all_the_voodo_here.c 2005-05-08 18:18:02 +0200 +0 -1
@@ -153,7 +154,6 @@
                                         myfree(subject);
                                         myfree(hdrline);
                                         myfree(unqp);
-                                       subject_present = 1;
                                         continue;
                                 }
                                 myfree(unqp);
#3 lore raw
In reply to Mads Martin Joergensen
Quoted 5 lines · Jakob Hirsch
Quoted 1 line

+ subject_present = 1;

It's there (a few lines below), but will only be done if the subject contains the prefix, which is obiously wrong.
sorry for that.

No worries--I've made .1 releases before :-)

do_all_the_voodo_here.c 2005-05-09 14:41:41 +0200 line 159

Quoted 13 lines

the extra setting of subject_present doesn't hurt, but for clarity, it's better to remove it:

do_all_the_voodo_here.c 2005-05-09 14:41:41 +0200 renamed from do_all_the_voodo_here.c 2005-05-08 18:18:02 +0200 +0 -1
@@ -153,7 +154,6 @@
                                        myfree(subject);
                                        myfree(hdrline);
                                        myfree(unqp);
-                                       subject_present = 1;
                                        continue;
                                }
                                myfree(unqp);

Yeah.

Signature · 4 lines
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.