Skip to contentSkip to conversation

drivers/char/hw_random.c: replace direct assignment with set_current_state()

PATCH In review [email protected] 2 participants 2 messages May 13, 2005 – May 14, 2005 Char and misc drivers

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 2/3 drivers/char/hw_random.c: replace direct assignment with set_current_state()

From: Christophe Lucas <[email protected]>

Use set_current_state() instead of direct assignment of current->state.

Signed-off-by Christophe Lucas <[email protected]>
Signed-off-by Domen Puncer <[email protected]>
---
 hw_random.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/char/hw_random.c +1 -1
Index: quilt/drivers/char/hw_random.c
===================================================================
@@ -514,7 +514,7 @@ static ssize_t rng_dev_read (struct file
 
 		if(need_resched())
 		{
-			current->state = TASK_INTERRUPTIBLE;
+			set_current_state(TASK_INTERRUPTIBLE);
 			schedule_timeout(1);
 		}
 		else

--

#1 lore raw
Quoted 20 lines · [email protected] wrote:

From: Christophe Lucas <[email protected]>

Use set_current_state() instead of direct assignment of current->state.

Signed-off-by Christophe Lucas <[email protected]>
Signed-off-by Domen Puncer <[email protected]>
---
 hw_random.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: quilt/drivers/char/hw_random.c
===================================================================

drivers/char/hw_random.c static ssize_t rng_dev_read (struct file · line 518

Quoted 6 lines
drivers/char/hw_random.c +1 -1
@@ -514,7 +514,7 @@ static ssize_t rng_dev_read (struct file
 
 		if(need_resched())
 		{
-			current->state = TASK_INTERRUPTIBLE;
+			set_current_state(TASK_INTERRUPTIBLE);
 			schedule_timeout(1);

full barriers and such don't seem needed.

Also, make sure to send driver patches to the driver author (me).

Jeff