Skip to contentSkip to conversation

Small nfs-utils patch

PATCH Olaf Kirch 2 participants 2 messages May 23, 2005 – Oct 7, 2005

Subsystems (2)
lore
Share & tools
lore

Olaf Kirch

author
#0 lore raw

Without this patch, showmount -e would sometimes display host names that should really have been subsumed under a wildcard entry.

The problem was that the code in get_exportlist would always skip the next group entry after removing one FQDN.

Olaf

Signature · 2 lines
Olaf Kirch   |  --- o --- Nous sommes du soleil we love when we play
[email protected] |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax

Without this patch, showmount -e would sometimes display host names that should really have been subsumed under a wildcard entry.

The problem was that the code in get_exportlist would always skip the next group entry after removing one FQDN.

utils/mountd/mountd.c +2 -4
Index: nfs-utils-1.0.7/utils/mountd/mountd.c
===================================================================
@@ -409,11 +409,9 @@ get_exportlist(void)
 				xfree(c->gr_name);
 				xfree(c);
 				xfree (hp);
-				if ((c = *cp) == NULL)
-				  break;
+				continue;
 			      }
-			      else
-				xfree (hp);
+			      xfree (hp);
 			    }
 			    cp = &(c->gr_next);
 			  }
#1 lore raw
Quoted 6 lines · On Monday May 23, [email protected] wrote:

Without this patch, showmount -e would sometimes display host names that should really have been subsumed under a wildcard entry.

The problem was that the code in get_exportlist would always skip the next group entry after removing one FQDN.

Thanks. I've committed it to the sourceforge CVS. (Hey, turn-around of less than 5 months! You can't complain about that!! :-)

NeilBrown

Quoted 23 lines

Olaf

Signature · 14 lines
Olaf Kirch   |  --- o --- Nous sommes du soleil we love when we play
[email protected] |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax

Without this patch, showmount -e would sometimes display
host names that should really have been subsumed under a
wildcard entry.

The problem was that the code in get_exportlist would always
skip the next group entry after removing one FQDN.

Signed-off-by: Olaf Kirch <[email protected]>

Index: nfs-utils-1.0.7/utils/mountd/mountd.c
===================================================================
utils/mountd/mountd.c +0 -0
@@ -409,11 +409,9 @@ get_exportlist(void)
 				xfree(c->gr_name);
 				xfree(c);
 				xfree (hp);

utils/mountd/mountd.c get_exportlist(void) · line 417

Quoted 10 lines
utils/mountd/mountd.c +2 -4
-				if ((c = *cp) == NULL)
-				  break;
+				continue;
 			      }
-			      else
-				xfree (hp);
+			      xfree (hp);
 			    }
 			    cp = &(c->gr_next);
 			  }

-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs