by smtp.nexlab.net (Postfix) with ESMTP id B7FC8FB7B for <[email protected]>; Tue, 24 May 2005 10:01:49 +0200 (CEST)
Received: ([email protected]) by vger.kernel.org via listexpand
id S261407AbVEXH3u (ORCPT <rfc822;[email protected]>); Tue, 24 May 2005 03:29:50 -0400
Received: ([email protected]) by vger.kernel.org id S261402AbVEXH3u
(ORCPT <rfc822;linux-kernel-outgoing>); Tue, 24 May 2005 03:29:50 -0400
Received: from ns2.suse.de ([195.135.220.15]:11926 "EHLO mx2.suse.de")
by vger.kernel.org with ESMTP id S261410AbVEXH3g (ORCPT <rfc822;[email protected]>); Tue, 24 May 2005 03:29:36 -0400
Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8])
(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 4FA8911A90; Tue, 24 May 2005 09:29:36 +0200 (CEST)
Date: Tue, 24 May 2005 09:29:29 +0200
From: Karsten Keil <[email protected]>
To: Aleksey Gorelov <[email protected]>
Cc: Ondrej Zary <[email protected]>,
[email protected], Andrew Morton <[email protected]>, [email protected]
Subject: Re: [PATCH] bug in VIA PCI IRQ routing
Message-ID: <[email protected]>
Mail-Followup-To: Aleksey Gorelov <[email protected]>,
Ondrej Zary <[email protected]>, [email protected], Andrew Morton <[email protected]>, [email protected]
References: <[email protected]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <[email protected]>
Organization: SuSE Linux AG
X-Operating-System: Linux 2.6.8-24.10-default i686
User-Agent: Mutt/1.5.6i
Sender: [email protected]
Precedence: bulk
X-Mailing-List: [email protected]
Hi,
Quoted 4 lines · Aleksey Gorelov
Karsten,
could you please verify if attached patch works for you ?
Works and seems to be OK, according to the specs. So this patch should go into the kernel, also into 2.4 I think. These chipset is still used on small special purpose systems.
arch/i386/pci/irq.c +22 -0
@@ -227,6 +227,24 @@ }/* +* The VIA pirq rules are nibble-based, like ALI, +* but without the ugly irq number munging. +* However, for 82C586, nibble map is different . +*/ +static int pirq_via586_get (struct pci_dev *router,struct pci_dev *dev,int pirq) +{ +static unsigned int pirqmap[4 ] = {3 ,2 ,5 ,1 }; +return read_config_nybble (router,0x55 , pirqmap[pirq-1 ]); +} + +static int pirq_via586_set (struct pci_dev *router,struct pci_dev *dev,int pirq,int irq) +{ +static unsigned int pirqmap[4 ] = {3 ,2 ,5 ,1 }; +write_config_nybble (router,0x55 , pirqmap[pirq-1 ], irq); +return 1 ; +} + +/* * ITE 8330G pirq rules are nibble-based * FIXME: pirqmap may be { 1, 0, 3, 2 }, * 2+3 are both mapped to irq 9 on my system
@@ -509,6 +527,10 @@switch (device) {case PCI_DEVICE_ID_VIA_82C586_0 : + r->name ="VIA" ; + r->get = pirq_via586_get; + r->set = pirq_via586_set; +return 1 ;case PCI_DEVICE_ID_VIA_82C596 :case PCI_DEVICE_ID_VIA_82C686 :case PCI_DEVICE_ID_VIA_8231 :
Signature · 8 lines
Karsten Keil SuSE Labs ISDN development - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/