Skip to contentSkip to conversation

enable PREEMPT_BKL on !PREEMPT+SMP too

PATCH In review Ingo Molnar 2 participants 2 messages May 26, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 enable PREEMPT_BKL on !PREEMPT+SMP too

the only sane way to clean up the current 3 lock_kernel() variants seems to be to remove the spinlock-based BKL implementations altogether, and to keep the semaphore-based one only. If we dont want to do that for whatever reason then i'm afraid we have to live with the current complexity. (but i'm open for other cleanup suggestions as well.)

to explore this possibility we'll (at a minimum) have to know whether the semaphore-based BKL works fine on plain SMP too. The patch below enables this.

the patch may make sense in isolation as well, as it might bring performance benefits: code that would formerly spin on the BKL spinlock will now schedule away and give up the CPU. It might introduce performance regressions as well, if any performance-critical code uses the BKL heavily and gets overscheduled due to the semaphore. I very much hope there is no such performance-critical codepath left though.

patch depends on:

consolidate-preempt-options-into-kernel-kconfigpreempt.patch

tested on x86-SMP. All other PREEMPT_BKL-using arches (x64, ppc64) should work fine too.

kernel/Kconfig.preempt renamed from kernel/Kconfig.preempt.orig +1 -1
@@ -13,7 +13,7 @@ config PREEMPT
 
 config PREEMPT_BKL
 	bool "Preempt The Big Kernel Lock"
-	depends on PREEMPT
+	depends on SMP || PREEMPT
 	default y
 	help
 	  This option reduces the latency of the kernel by making the
#1 lore raw
Quoted 4 lines · Ingo Molnar

It might introduce
performance regressions as well, if any performance-critical code uses the BKL heavily and gets overscheduled due to the semaphore. I very much hope there is no such performance-critical codepath left though.

A write-intensive benchmark on a reiser3 FS is probably a good place to start testing.

Lee