Skip to contentSkip to conversation

fusion - sas support

PATCH In review Moore, Eric Dean 2 participants 2 messages Jun 1, 2005

Subsystems (2)
SCSI LSI Logic MPT fusion drivers (FC/SAS/SPI)
lore
Share & tools
lore

Moore, Eric Dean

author
#0 lore raw

PATCH 1/4 fusion - sas support

mptfusion patch 1/4:

This patch can also be found at this URL:
ftp://ftp.lsil.com/HostAdapterDrivers/linux/Fusion-MPT/2.6-kernel/3.03.03/

Changelog:
* adding support for new module in Kconfig and Makefile
* adding mptsas.c module

Signed-off-by Eric.Moore<[email protected]>
drivers/message/fusion/Kconfig +16 -0
@@ -35,6 +35,22 @@
 	  LSIFC929X
 	  LSIFC929XL
 
+config FUSION_SAS
+	tristate "Fusion MPT ScsiHost drivers for SAS"
+	depends on PCI && SCSI
+	select FUSION
+	---help---
+	  SCSI HOST support for a SAS host adapters.
+
+	  List of supported controllers:
+
+	  LSISAS1064
+	  LSISAS1066
+	  LSISAS1068
+	  LSISAS1064E
+	  LSISAS1066E
+	  LSISAS1068E
+
 config FUSION_MAX_SGE
 	int "Maximum number of scatter gather entries (16 - 128)"
 	depends on FUSION
drivers/message/fusion/Makefile +1 -0
@@ -34,5 +34,6 @@
 
 obj-$(CONFIG_FUSION_SPI)	+= mptbase.o mptscsih.o mptspi.o
 obj-$(CONFIG_FUSION_FC)		+= mptbase.o mptscsih.o mptfc.o
+obj-$(CONFIG_FUSION_SAS)	+= mptbase.o mptscsih.o mptsas.o
 obj-$(CONFIG_FUSION_CTL)	+= mptctl.o
 obj-$(CONFIG_FUSION_LAN)	+= mptlan.o
drivers/message/fusion/mptsas.c +467 -0

467 lines not on this page · raw message

#1 lore raw
Quoted 3 lines · Eric Dean

Changelog:
* adding support for new module in Kconfig and Makefile
* adding mptsas.c module

No to this one until you and Adaptec (and any other interested parties) get the sas transport class sorted out and in use ... at least in embryo. I won't hold the drivers up while the fine details and code location is sorted out, but we need to get at least the structure in place.

Additionally:

drivers/message/fusion/mptsas.c line 96

Quoted 7 lines
drivers/message/fusion/mptsas.c +7 -0
+static struct device_attribute mptsas_queue_depth_attr = {
+       .attr = {
+               .name =         "queue_depth",
+               .mode =         S_IWUSR,
+       },
+       .store = mptscsih_store_queue_depth,
+};

This can all be done with the change_queue_depth host template API.

There are also a suspicious lot of SPI strings in the SAS driver (are these cut and paste issues?):

Quoted 7 lines
(quoted diff) +3 -0
+       .name                           = "MPT SPI Host",
 
+       mptsasDoneCtx = mpt_register(mptscsih_io_done, MPTSPI_DRIVER);
+       mptsasTaskCtx = mpt_register(mptscsih_taskmgmt_complete,

MPTSPI_DRIVER);
+ mptsasInternalCtx = mpt_register(mptscsih_scandv_complete,
MPTSPI_DRIVER);

James