isdn: copy_from_user size fix in sc/ioctl.c
PATCH 1/1 isdn: copy_from_user size fix in sc/ioctl.c
A few lines above the patch we have:
char *srec; srec = kmalloc(SCIOC_SRECSIZE, GFP_KERNEL);
sizeof pointer is probably not meant here.
Signed-off-by Domen Puncer <[email protected]>
drivers/isdn/sc/ioctl.c +2 -2
@@ -72,14 +72,14 @@ int sc_ioctl(int card, scs_ioctl *data)/* * Get the SRec from user space */ -if (copy_from_user (srec, data->dataptr,sizeof (srec))) { +if (copy_from_user (srec, data->dataptr,SCIOC_SRECSIZE )) {kfree (rcvmsg);kfree (srec);return -EFAULT ; } status =send_and_receive (card,CMPID , cmReqType2, cmReqClass0, cmReqLoadProc, -0 ,sizeof (srec), srec, rcvmsg,SAR_TIMEOUT ); +0 ,SCIOC_SRECSIZE , srec, rcvmsg,SAR_TIMEOUT );kfree (rcvmsg);kfree (srec);
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors