possible error in EXIT_DEAD transformation
PATCH 1/1 possible error in EXIT_DEAD transformation
This assignment may have been missed, when TASK_DEAD was converted over to EXIT_DEAD.
Signed-off-by Joe Korty <[email protected]>
2.6.12-rc6-git7-jak/kernel/sched.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
kernel/sched.c renamed from kernel/sched.c~possibly.erronous.task_state.assignment +1 -1
@@ -2664,7 +2664,7 @@ need_resched_nonpreemptible:spin_lock_irq (&rq->lock);if (unlikely (prev->flags &PF_DEAD )) - prev->state =EXIT_DEAD ; + prev->exit_state =EXIT_DEAD ; switch_count = &prev->nivcsw;if (prev->state && !(preempt_count () &PREEMPT_ACTIVE )) {
_
kernel/sched.c need_resched_nonpreemptible: · line 2667
Quoted 9 lines · Joe Korty
This assignment may have been missed, when
TASK_DEADwas converted over toEXIT_DEAD.kernel/sched.c renamed from kernel/sched.c~possibly.erronous.task_state.assignment +1
-1@@ -2664,7 +2664,7 @@ need_resched_nonpreemptible:spin_lock_irq (&rq->lock);if (unlikely (prev->flags &PF_DEAD )) - prev->state =EXIT_DEAD ; + prev->exit_state =EXIT_DEAD ;
no, here we set the dead task's state to EXIT_DEAD, so that it does not come back on the runqueue. Its ->exit_state is already EXIT_DEAD (or EXIT_ZOMBIE).
Ingo