Skip to contentSkip to conversation

silence cs89x0

PATCH New Denis Vlasenko 1 participant 1 message Jun 17, 2005 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 silence cs89x0

Hi Jeff,

cs89x0 talks a lot at boot. Seems like debug leftover. This patch downgrades printks to KERN_DEBUG. While we're at it, make these messages a bit less obscure. --
vda

cs89x0:cs89x0_probe(0x0)
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
PP_addr=0xffff
eth1: incorrect signature 0xffff
cs89x0: no cs8900 or cs8920 detected. Be sure to disable PnP with SETUP

drivers/net/cs89x0.h renamed from drivers/net/cs89x0.h.orig +1 -0
@@ -93,6 +93,7 @@
 #endif
 
 #define CHIP_EISA_ID_SIG 0x630E   /*  Product ID Code for Crystal Chip (CS8900 spec 4.3) */
+#define CHIP_EISA_ID_SIG_STR "0x630E"
 
 #ifdef IBMEIPKT
 #define EISA_ID_SIG 0x4D24	/*  IBM */
drivers/net/cs89x0.c renamed from drivers/net/cs89x0.c.orig +8 -4
@@ -416,6 +416,7 @@ cs89x0_probe1(struct net_device *dev, in
 	struct net_local *lp = netdev_priv(dev);
 	static unsigned version_printed;
 	int i;
+	int tmp;
 	unsigned rev_type = 0;
 	int eeprom_buff[CHKSUM_LEN];
 	int retval;
@@ -467,14 +468,17 @@ cs89x0_probe1(struct net_device *dev, in
 				goto out2;
 			}
 	}
-printk("PP_addr=0x%x\n", inw(ioaddr + ADD_PORT));
+	printk(KERN_DEBUG "PP_addr at %x: 0x%x\n",
+			ioaddr + ADD_PORT, inw(ioaddr + ADD_PORT));
 
 	ioaddr &= ~3;
 	outw(PP_ChipID, ioaddr + ADD_PORT);
 
-	if (inw(ioaddr + DATA_PORT) != CHIP_EISA_ID_SIG) {
-		printk(KERN_ERR "%s: incorrect signature 0x%x\n",
-			dev->name, inw(ioaddr + DATA_PORT));
+	tmp = inw(ioaddr + DATA_PORT);
+	if (tmp != CHIP_EISA_ID_SIG) {
+		printk(KERN_DEBUG "%s: incorrect signature at %x: 0x%x!="
+			CHIP_EISA_ID_SIG_STR "\n",
+			dev->name, ioaddr + DATA_PORT, tmp);
   		retval = -ENODEV;
   		goto out2;
 	}