Skip to contentSkip to conversation

list_for_each_entry: fs-dquot.c

PATCH In review [email protected] 2 participants 2 messages Jun 21, 2005 – Jun 23, 2005 VFS

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 list_for_each_entry: fs-dquot.c

From: Domen Puncer <[email protected]>

Make code more readable with list_for_each_entry_safe.

Signed-off-by Domen Puncer <[email protected]>
Signed-off-by Maximilian Attems <[email protected]>
Signed-off-by Domen Puncer <[email protected]>
---
 dquot.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
fs/dquot.c +2 -5
Index: quilt/fs/dquot.c
===================================================================
@@ -409,13 +409,10 @@ out_dqlock:
  * for this sb+type at all. */
 static void invalidate_dquots(struct super_block *sb, int type)
 {
-	struct dquot *dquot;
-	struct list_head *head;
+	struct dquot *dquot, *tmp;
 
 	spin_lock(&dq_list_lock);
-	for (head = inuse_list.next; head != &inuse_list;) {
-		dquot = list_entry(head, struct dquot, dq_inuse);
-		head = head->next;
+	list_for_each_entry_safe(dquot, tmp, &inuse_list, dq_inuse) {
 		if (dquot->dq_sb != sb)
 			continue;
 		if (dquot->dq_type != type)

--

reviewer
#1 lore raw

Hello,

Quoted 5 lines

From: Domen Puncer <[email protected]>

Make code more readable with list_for_each_entry_safe.

Thanks for the patch. I've forwarded it to Andrew Morton with my ACK.

Honza