Skip to contentSkip to conversation

__leify posix_acl_xattr_entry, posix_acl_xattr_header

PATCH Alexey Dobriyan 2 participants 2 messages Jun 22, 2005 – Jun 26, 2005

lore
Share & tools
lore
#0 lore raw

Christoph, can you comment on what Steve said to my patch which is exactly the same as yours acl-endianess-annotations.patch?
============================================================================
From: Steven French <[email protected]>

You may be correct, but making the in memory representations of these structions little endian seems wrong and I would be surprised if it were little endian, but I have not had time to think through what happens when a local filesystem takes an existing hard drive with ACLs on various inodes and moves the drive from a little endian to a big endian machine and the endian implications on this structure.

Although the representation on the wire for the cifs protocol is clearly little endian for the acl entries, I am uncomfortable with changes to the in memory representation until I do more checking.
============================================================================

include/linux/posix_acl_xattr.h renamed from include/linux/posix_acl_xattr.h~acl-endianess-annotations +4 -4
@@ -23,13 +23,13 @@
 #define ACL_UNDEFINED_ID	(-1)
 
 typedef struct {
-	__u16			e_tag;
-	__u16			e_perm;
-	__u32			e_id;
+	__le16			e_tag;
+	__le16			e_perm;
+	__le32			e_id;
 } posix_acl_xattr_entry;
 
 typedef struct {
-	__u32			a_version;
+	__le32			a_version;
 	posix_acl_xattr_entry	a_entries[0];
 } posix_acl_xattr_header;
 
#1 lore raw
Quoted 2 lines · Alexey Dobriyan

Christoph, can you comment on what Steve said to my patch which is exactly the same as yours acl-endianess-annotations.patch?

Sure.

Quoted 10 lines

============================================================================
From: Steven French <[email protected]>

You may be correct, but making the in memory representations of these structions little endian seems wrong and I would be surprised if it were little endian, but I have not had time to think through what happens when a local filesystem takes an existing hard drive with ACLs on various inodes and moves the drive from a little endian to a big endian machine and the endian implications on this structure.

Quoted 3 lines

Although the representation on the wire for the cifs protocol is clearly little endian for the acl entries, I am uncomfortable with changes to the in memory representation until I do more checking.

I have asked myself that question aswell. The odd thing about our posix ACL implementation is that the ACL data passed to the xattr syscalls is _always_ little endian, which is what the structure in this file define.

The incore represenation is in posix_acl.h and is always little endian.