Skip to contentSkip to conversation

(3/4) ieee1394 - uninitialize static variables

PATCH New Carlo Perassi 1 participant 1 message Jun 23, 2005 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 (3/4) ieee1394 - uninitialize static variables

Hi.

One of the tasks at http://janitor.kernelnewbies.org/TODO
is described as
"
uninitialize static variables initialized to 0, to make it go to the .bss, instead of .data.
"

To proof that it is still guaranteed that those variables will be initialized to zero

Tom Bradley <[email protected]> (on the kernel-janitors mailing list) wrote
"
the default for gcc is `-fzero-initialized-in-bss', the kernel makefile does not change this therefore bss is zeroed, this is documented in the gcc manpage.
"

and David P Howell <[email protected]> added that "
By definition .bss is always zero'ed by the implementation. "

This patch uninitializes a static int initialized to 0.

---
 drivers/ieee1394/pcilynx.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/ieee1394/pcilynx.c +1 -1
Index: linux-2.6.12/drivers/ieee1394/pcilynx.c
===================================================================
@@ -76,7 +76,7 @@
 
 
 /* Module Parameters */
-static int skip_eeprom = 0;
+static int skip_eeprom;
 module_param(skip_eeprom, int, 0444);
 MODULE_PARM_DESC(skip_eeprom, "Use generic bus info block instead of serial eeprom (default = 0).");
 
Signature · 1 line
Carlo Perassi - http://www.linux.it/~carlo/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors