Skip to contentSkip to conversation

recent kprobe work

DISCUSSION David S. Miller 3 participants 3 messages Jun 28, 2005 – Jun 29, 2005

lore
Share & tools
lore
#0 lore raw

Can the folks submitting all of the kprobe stuff at least consult me when they can't figure out how to implement the sparc64 kprobe variant for new features?

Currently, the sparc64 build is broken by recent kprobe changes:

kernel/built-in.o: In function `init_kprobes':
: undefined reference to `arch_init'

Also, can we use a more namespace friendly name for this kprobe layer specific function other than "arch_init()"?

Thanks.

#1 lore raw
Quoted 8 lines · David S. Miller

Can the folks submitting all of the kprobe stuff at least consult me when they can't figure out how to implement the sparc64 kprobe variant for new features?

Currently, the sparc64 build is broken by recent kprobe changes:

Quoted 7 lines

kernel/built-in.o: In function `init_kprobes':
: undefined reference to `arch_init'

Also, can we use a more namespace friendly name for this kprobe layer specific function other than "arch_init()"?

Thanks.

Sorry, just an oversight. We have several arch_* functions, maybe we should start using kprobes_arch_* instead.

    --rusty
#2 lore raw
Quoted 13 lines · Rusty Lynch
Quoted 11 lines · David S. Miller

Can the folks submitting all of the kprobe stuff at least consult me when they can't figure out how to implement the sparc64 kprobe variant for new features?

Currently, the sparc64 build is broken by recent kprobe changes:

kernel/built-in.o: In function `init_kprobes':
: undefined reference to `arch_init'

Quoted 8 lines
Quoted 4 lines

Also, can we use a more namespace friendly name for this kprobe layer specific function other than "arch_init()"?

Thanks.

Sorry, just an oversight. We have several arch_* functions, maybe we should start using kprobes_arch_* instead.

Absolutely - please send a patch once Dave's fix is merged up.

Dave: sorry, I would have caught the missing reference except I'm totally averse to `make allfooconfig' on non-x86[_64] architectures because so much stuff simply doesn't work.

But lo. It does work on sparc64.