Use copy_from_user when accessing guest_pt[]
PATCH 10/10 Use copy_from_user when accessing guest_pt[]
Use copy_from_user when accessing guest_pt[]
Signed-off-by Arun Sharma <[email protected]>
xen/arch/x86/shadow.c +6 -2
@@ -1906,7 +1906,7 @@ unsigned long gpfn, unsigned index) {unsigned long smfn =__shadow_status (d, gpfn, PGT_snapshot); -l1_pgentry_t *snapshot;// could be L1s or L2s or ... +l1_pgentry_t *snapshot, gpte;// could be L1s or L2s or ... int entries_match;perfc_incrc (snapshot_entry_matches_calls);
@@ -1916,10 +1916,14 @@ snapshot =map_domain_page (smfn); +if (__copy_from_user (&gpte, &guest_pt[index], +sizeof (gpte))) +return 0 ; +// This could probably be smarter, but this is sufficent for // our current needs. // - entries_match = !l1e_has_changed (guest_pt[index], snapshot[index], + entries_match = !l1e_has_changed (gpte, snapshot[index],PAGE_FLAG_MASK );unmap_domain_page (snapshot);