reiser BUG in 2.6.13-rc1

PATCH In review Jens Axboe 3 participants 3 messages Jun 30, 2005

lore

Share & tools

lore

Jens Axboe

author

2005-06-30 10:10 UTC #0 lore raw

PATCH 1/1 reiser BUG in 2.6.13-rc1

Hi,

Reiser is derefencing an uninitialized pointer, causing an oops on boot.

Signed-off-by Jens Axboe <[email protected]>

fs/reiserfs/super.c +1 -2

@@ -1053,10 +1053,9 @@ static void handle_barrier_mode(struct s
 
 static void handle_attrs( struct super_block *s )
 {
-	struct reiserfs_super_block * rs;
+	struct reiserfs_super_block * rs = SB_DISK_SUPER_BLOCK (s);
 
 	if( reiserfs_attrs( s ) ) {
-		rs = SB_DISK_SUPER_BLOCK (s);
 		if( old_format_only(s) ) {
 			reiserfs_warning(s, "reiserfs: cannot support attributes on 3.5.x disk format" );
 			REISERFS_SB(s) -> s_mount_opt &= ~ ( 1 << REISERFS_ATTRS );

Signature · 1 line

Jens Axboe

Hans Reiser

2005-06-30 17:42 UTC #1 lore raw

Quoted 14 lines · Jens Axboe

Hi,
Reiser is derefencing an uninitialized pointer, causing an oops on boot.
Signed-off-by Jens Axboe <[email protected]>
fs/reiserfs/super.c +0 -0
@@ -1053,10 +1053,9 @@ static void handle_barrier_mode(struct s
 

fs/reiserfs/super.c static void handle_barrier_mode(struct s · line 1061

Quoted 10 lines

fs/reiserfs/super.c +1 -2

 static void handle_attrs( struct super_block *s )
 {
-	struct reiserfs_super_block * rs;
+	struct reiserfs_super_block * rs = SB_DISK_SUPER_BLOCK (s);
 
 	if( reiserfs_attrs( s ) ) {
-		rs = SB_DISK_SUPER_BLOCK (s);
 		if( old_format_only(s) ) {
 			reiserfs_warning(s, "reiserfs: cannot support attributes on 3.5.x disk format" );
 			REISERFS_SB(s) -> s_mount_opt &= ~ ( 1 << REISERFS_ATTRS );

Thanks Jens.

Edward, how is the fedora boot bug finding going? Is this it by any chance?

Hans

Edward Shishkin

2005-06-30 18:49 UTC #2 lore raw

Quoted 32 lines · Hans Reiser

Quoted 16 lines · Jens Axboe
Hi,
Reiser is derefencing an uninitialized pointer, causing an oops on boot.
Signed-off-by Jens Axboe <[email protected]>
fs/reiserfs/super.c +0 -0
@@ -1053,10 +1053,9 @@ static void handle_barrier_mode(struct s
 
fs/reiserfs/super.c static void handle_barrier_mode(struct s · line 1061
Quoted 10 lines
fs/reiserfs/super.c +1 -2
 static void handle_attrs( struct super_block *s )
 {
-	struct reiserfs_super_block * rs;
+	struct reiserfs_super_block * rs = SB_DISK_SUPER_BLOCK (s);
 
 	if( reiserfs_attrs( s ) ) {
-		rs = SB_DISK_SUPER_BLOCK (s);
 		if( old_format_only(s) ) {
 			reiserfs_warning(s, "reiserfs: cannot support attributes on 3.5.x disk format" );
 			REISERFS_SB(s) -> s_mount_opt &= ~ ( 1 << REISERFS_ATTRS );
Thanks Jens.

Quoted 5 lines

Edward, how is the fedora boot bug finding going? Is this it by any chance?
Hans

FC4-test3 with root on reiserfs has been successfully booted with another miniinstall CD, so it seems that something wrong in grub.
Unfortunately FC was installed on the workstation which currently is used for intensive benchmarking, so the following is still in todo-list:
- hacking grub
- investigating reiserfs+selinux

Thanks,
Edward.