Skip to contentSkip to conversation

Fix menuconfig error message

PATCH In review Kurt Wall 2 participants 2 messages Jul 4, 2005

lore
Share & tools
lore

Kurt Wall

author
#0 lore raw

PATCH 1/1 Fix menuconfig error message

If you try to run `make menuconfig' on a system that lacks ncurses development libs, you get an error message telling you to install ncurses-devel. Some popular distributions don't have an ncurses-devel package. This patch generalizes the error message. Patch is against 2.6.12.

This patch fixes a silly typo conflating RPM-based systems with Debian derivatives and adds the name of the Debian package to install.

MAINTAINERS doesn't list a maintainer for menuconfig or lxdialog, so I sent this to lkml, kbuild-devel, and to the kconfig maintainer.

scripts/lxdialog/Makefile +5 -2
@@ -35,8 +35,11 @@
 		echo -e "\007" ;\
 		echo ">> Unable to find the Ncurses libraries." ;\
 		echo ">>" ;\
-		echo ">> You must install ncurses-devel in order" ;\
-		echo ">> to use 'make menuconfig'" ;\
+		echo ">> You must install ncurses development libraries" ;\
+		echo ">> to use 'make menuconfig'. If you have an RPM-based" ;\
+		echo ">> distribution you should install the ncurses-devel" ;\
+		echo ">> Debian users will probably want to install the
+		echo ">> libncurses5-dev package." ;\
 		echo ;\
 		exit 1 ;\
 	fi
Signature · 3 lines
Rule of Feline Frustration:
	When your cat has fallen asleep on your lap and looks utterly
content and adorable, you will suddenly have to go to the bathroom.
#1 lore raw

Hi,

Quoted 6 lines · Kurt Wall
scripts/lxdialog/Makefile +0 -0
@@ -35,8 +35,11 @@
 		echo -e "\007" ;\
 		echo ">> Unable to find the Ncurses libraries." ;\
 		echo ">>" ;\

scripts/lxdialog/Makefile line 45

Quoted 10 lines
scripts/lxdialog/Makefile +5 -2
-		echo ">> You must install ncurses-devel in order" ;\
-		echo ">> to use 'make menuconfig'" ;\
+		echo ">> You must install ncurses development libraries" ;\
+		echo ">> to use 'make menuconfig'. If you have an RPM-based" ;\
+		echo ">> distribution you should install the ncurses-devel" ;\
+		echo ">> Debian users will probably want to install the
+		echo ">> libncurses5-dev package." ;\
 		echo ;\
 		exit 1 ;\
 	fi

I would prefer if we don't mention special distributions or version numbers and just mentioned a few common package names.
On Debian libncurses-dev or ncurses-dev works as well and so is better than libncurses5-dev.

bye, Roman