Skip to contentSkip to conversation

rt-preempt build failure

DISCUSSION Con Kolivas 2 participants 5 messages Jul 5, 2005 – Jul 6, 2005

lore
Share & tools
lore
#0 lore raw

Hi Ingo

This config on i386:
http://ck.kolivas.org/crap/rt-config

realtime-preempt-2.6.12-final-V0.7.50-51
fails to build with these errors:

kernel/rt.c: In function `__down_mutex':
kernel/rt.c:1264: error: `ti' undeclared (first use in this function) kernel/rt.c:1264: error: (Each undeclared identifier is reported only once kernel/rt.c:1264: error: for each function it appears in.) kernel/rt.c:1264: error: task' undeclared (first use in this function) kernel/rt.c:1264: error: old_owner' undeclared (first use in this function) kernel/rt.c:1264: error: too many arguments to function ____down_mutex' kernel/rt.c: In function __down':
kernel/rt.c:1269: error: ti' undeclared (first use in this function) kernel/rt.c:1269: error: task' undeclared (first use in this function) kernel/rt.c:1269: error: old_owner' undeclared (first use in this function) kernel/rt.c:1269: error: too many arguments to function ____down'

Cheers,
Con

#1 lore raw
Quoted 7 lines · Con Kolivas

Hi Ingo

This config on i386:
http://ck.kolivas.org/crap/rt-config

realtime-preempt-2.6.12-final-V0.7.50-51
fails to build with these errors:

thanks, i have fixed this and have uploaded the -51-00 patch.

Ingo

#2 lore raw
Quoted 10 lines · Ingo Molnar
Quoted 7 lines · Con Kolivas

Hi Ingo

This config on i386:
http://ck.kolivas.org/crap/rt-config

realtime-preempt-2.6.12-final-V0.7.50-51
fails to build with these errors:

thanks, i have fixed this and have uploaded the -51-00 patch.

Thanks. boots and runs stable after a swag of these initially (?netconsole related):

BUG: scheduling with irqs disabled: swapper/0x00000000/1
caller is __down_mutex+0x143/0x200
 [<c02dd908>] schedule+0x95/0xf5 (8)
 [<c02de5b6>] __down_mutex+0x143/0x200 (28)
 [<c02422c3>] b44_start_xmit+0x23/0x3ee (84)
 [<c0292beb>] find_skb+0xa4/0xe4 (8)
 [<c0292c3e>] netpoll_send_skb+0x13/0xb0 (48)
 [<c0243dcb>] write_msg+0x5f/0xb6 (16)
 [<c0243d6c>] write_msg+0x0/0xb6 (12)
 [<c011c3e1>] __call_console_drivers+0x41/0x4d (8)
 [<c011c551>] call_console_drivers+0xec/0x109 (20)
 [<c011c973>] release_console_sem+0x24/0xd4 (32)
 [<c0243e7e>] init_netconsole+0x40/0x74 (24)
 [<c03fa9ac>] do_initcalls+0x55/0xc7 (12)
 [<c010038b>] init+0x8a/0x1b3 (32)
 [<c0100301>] init+0x0/0x1b3 (16)
 [<c0100f71>] kernel_thread_helper+0x5/0xb (8)

There's a 75KB dmesg with all of them (not sure if any differ) here:
http://ck.kolivas.org/crap/rt.dmesg

same config:
http://ck.kolivas.org/crap/rt-config

Cheers,
Con

#3 lore raw
Quoted 14 lines · Con Kolivas
Quoted 1 line

thanks, i have fixed this and have uploaded the -51-00 patch.

Thanks. boots and runs stable after a swag of these initially (?netconsole related):

BUG: scheduling with irqs disabled: swapper/0x00000000/1
caller is __down_mutex+0x143/0x200
 [<c02dd908>] schedule+0x95/0xf5 (8)
 [<c02de5b6>] __down_mutex+0x143/0x200 (28)
 [<c02422c3>] b44_start_xmit+0x23/0x3ee (84)
 [<c0292beb>] find_skb+0xa4/0xe4 (8)
 [<c0292c3e>] netpoll_send_skb+0x13/0xb0 (48)
 [<c0243dcb>] write_msg+0x5f/0xb6 (16)
 [<c0243d6c>] write_msg+0x0/0xb6 (12)
Quoted 8 lines
 [<c011c3e1>] __call_console_drivers+0x41/0x4d (8)
 [<c011c551>] call_console_drivers+0xec/0x109 (20)
 [<c011c973>] release_console_sem+0x24/0xd4 (32)
 [<c0243e7e>] init_netconsole+0x40/0x74 (24)
 [<c03fa9ac>] do_initcalls+0x55/0xc7 (12)
 [<c010038b>] init+0x8a/0x1b3 (32)
 [<c0100301>] init+0x0/0x1b3 (16)
 [<c0100f71>] kernel_thread_helper+0x5/0xb (8)

ok, the patch below (or -51-04 and later kernels) should fix this one. printk is fully preemptible from now on - lets see how it works out in practice. (i kept it under irqs-off to make sure we get all crash messages out. Perhaps we could disable irqs/preemption if oops_in_progress?) This patch should also fix similar, fbcon related messages.

Ingo

kernel/printk.c +1 -2
Index: linux/kernel/printk.c
===================================================================
@@ -738,9 +738,8 @@ void release_console_sem(void)
 		_con_start = con_start;
 		_log_end = log_end;
 		con_start = log_end;		/* Flush */
-		spin_unlock(&logbuf_lock);
+		spin_unlock_irq(&logbuf_lock);
 		call_console_drivers(_con_start, _log_end);
-		raw_local_irq_restore(flags);
 	}
 	console_locked = 0;
 	console_may_schedule = 0;
#4 lore raw
Quoted 6 lines · Ingo Molnar
Quoted 4 lines · Con Kolivas
Quoted 1 line

thanks, i have fixed this and have uploaded the -51-00 patch.

Thanks. boots and runs stable after a swag of these initially (?netconsole related):

Quoted 6 lines

ok, the patch below (or -51-04 and later kernels) should fix this one. printk is fully preemptible from now on - lets see how it works out in practice. (i kept it under irqs-off to make sure we get all crash messages out. Perhaps we could disable irqs/preemption if oops_in_progress?) This patch should also fix similar, fbcon related messages.

Works fine, thanks!

Con