Skip to contentSkip to conversation

is_broadcast_ether_addr() is still required

PATCH In review Adrian Bunk 2 participants 2 messages Jul 8, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 is_broadcast_ether_addr() is still required

This patch by Bernhard Rosenkraenzer <[email protected]> is still required to fix the following compile error:

<-- snip -->

...
CC drivers/net/wireless/ipw2200.o
...
drivers/net/wireless/ipw2200.c: In function `ipw_rx':
drivers/net/wireless/ipw2200.c:4937: warning: implicit declaration of function `is_broadcast_ether_addr'
...
CC net/ieee80211/ieee80211_tx.o
net/ieee80211/ieee80211_tx.c: In function `ieee80211_xmit':
net/ieee80211/ieee80211_tx.c:341: warning: implicit declaration of function `is_broadcast_ether_addr'
...
LD .tmp_vmlinux1
drivers/built-in.o(.text+0x422abc): In function `ipw_rx':
: undefined reference to `is_broadcast_ether_addr'
drivers/built-in.o(.text+0x4233f6): In function `ipw_rx':
: undefined reference to `is_broadcast_ether_addr'
drivers/built-in.o(.text+0x426b9f): In function
`ipw_net_hard_start_xmit':
: undefined reference to `is_broadcast_ether_addr'
drivers/built-in.o(.text+0x426f9d): In function
`ipw_net_hard_start_xmit':
: undefined reference to `is_broadcast_ether_addr'
net/built-in.o(.text+0x1e73c6): In function `ieee80211_xmit':
: undefined reference to `is_broadcast_ether_addr'
make: *** [.tmp_vmlinux1] Error 1

<-- snip -->

is_broadcast_ether_addr() was removed but it's still used.

include/net/ieee80211.h renamed from include/net/ieee80211.h.ark +5 -0
@@ -627,6 +627,11 @@
 #define MAC_FMT "%02x:%02x:%02x:%02x:%02x:%02x"
 #define MAC_ARG(x) ((u8*)(x))[0],((u8*)(x))[1],((u8*)(x))[2],((u8*)(x))[3],((u8*)(x))[4],((u8*)(x))[5]
 
+extern inline int is_broadcast_ether_addr(const u8 *addr)
+{
+	return ((addr[0] == 0xff) && (addr[1] == 0xff) && (addr[2] == 0xff) &&
+		(addr[3] == 0xff) && (addr[4] == 0xff) && (addr[5] == 0xff));
+}
 
 #define CFG_IEEE80211_RESERVE_FCS (1<<0)
 #define CFG_IEEE80211_COMPUTE_FCS (1<<1)
#1 lore raw
Quoted 3 lines · Adrian Bunk

This patch by Bernhard Rosenkraenzer <[email protected]> is still required to fix the following compile error:

I think this problem is due to my failure to navigate the miasma of Jeff's git trees. I need to go in and look at all his branches and work out what's missing.