Skip to contentSkip to conversation

scsi/osst: use msleep() instead of schedule_timeout()

PATCH New [email protected] 1 participant 1 message Jul 14, 2005 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi/osst: use msleep() instead of schedule_timeout()

From: Nishanth Aravamudan <[email protected]>

Replace schedule_timeout() with msleep() to guarantee the task delays as expected.

Patch is compile-tested.

---
 osst.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)
drivers/scsi/osst.c +3 -6
Index: quilt/drivers/scsi/osst.c
===================================================================
@@ -863,8 +863,7 @@ static int osst_recover_wait_frame(struc
 				retval = osst_write_error_recovery(STp, aSRpnt, 0);
 				break;
 			}
-			set_current_state(TASK_INTERRUPTIBLE);
-			schedule_timeout (HZ / OSST_POLL_PER_SEC);
+			msleep(1000 / OSST_POLL_PER_SEC);
 
 			STp->buffer->b_data = mybuf; STp->buffer->buffer_size = 24;
 			memset(cmd, 0, MAX_COMMAND_SIZE);
@@ -1559,8 +1558,7 @@ static int osst_reposition_and_retry(str
 			osst_set_frame_position(STp, aSRpnt, frame + skip, 1);
 			flag = 0;
 			attempts--;
-			set_current_state(TASK_INTERRUPTIBLE);
-			schedule_timeout(HZ / 10);
+			msleep(100);
 		}
 		if (osst_get_frame_position(STp, aSRpnt) < 0) {		/* additional write error */
 #if DEBUG
@@ -1621,8 +1619,7 @@ static int osst_reposition_and_retry(str
 			debugging = 0;
 		}
 #endif
-		set_current_state(TASK_INTERRUPTIBLE);
-		schedule_timeout(HZ / 10);
+		msleep(100);
 	}
 	printk(KERN_ERR "%s:E: Failed to find valid tape media\n", name);
 #if DEBUG

--