Skip to contentSkip to conversation

EXIT_CONNECTOR and FORK_CONNECTOR must depend on NET

PATCH In review Adrian Bunk 2 participants 2 messages Jul 17, 2005 – Jul 18, 2005 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EXIT_CONNECTOR and FORK_CONNECTOR must depend on NET

If you select some variable, you have to ensure that the dependencies of the select'ed variable are fulfilled.

This patch fixes the following link error:

<-- snip -->

...
LD .tmp_vmlinux1
drivers/built-in.o: In function `cn_netlink_send':
: undefined reference to `alloc_skb'
drivers/built-in.o: In function `cn_netlink_send':
: undefined reference to netlink_broadcast' drivers/built-in.o: In function cn_netlink_send':
: undefined reference to __kfree_skb' drivers/built-in.o: In function cn_netlink_send':
: undefined reference to skb_over_panic' drivers/built-in.o: In function cn_rx_skb':
connector.c:(.text+0x20d809): undefined reference to __kfree_skb' drivers/built-in.o: In function cn_input':
connector.c:(.text+0x20d91e): undefined reference to skb_dequeue' drivers/built-in.o: In function cn_init':
connector.c:(.text+0x20dedc): undefined reference to `netlink_kernel_create'
connector.c:(.text+0x20df67): undefined reference to sock_release' drivers/built-in.o: In function kfree_skb':
connector.c:(.text+0x20d756): undefined reference to __kfree_skb' drivers/built-in.o: In function cn_rx_skb':
connector.c:(.text+0x20d7c8): undefined reference to __kfree_skb' connector.c:(.text+0x20d87e): undefined reference to __kfree_skb' drivers/built-in.o: In function `cn_fini':
connector.c:(.text+0x20dfae): undefined reference to sock_release' drivers/built-in.o: In function w1_alloc_dev':
make: *** [.tmp_vmlinux1] Error 1

<-- snip -->

drivers/connector/Kconfig renamed from drivers/connector/Kconfig.old +2 -0
@@ -1,35 +1,37 @@
 menu "Connector - unified userspace <-> kernelspace linker"
 
 config CONNECTOR
 	tristate "Connector - unified userspace <-> kernelspace linker"
 	depends on NET
 	---help---
 	  This is unified userspace <-> kernelspace connector working on top
 	  of the netlink socket protocol.
 
 	  Connector support can also be built as a module.  If so, the module
 	  will be called cn.ko.
 
 config EXIT_CONNECTOR
 	bool "Enable exit connector"
+	depends on NET
 	select CONNECTOR
 	default y
 	---help---
 	  It adds a connector in kernel/exit.c:do_exit() function. When a exit
 	  occurs, netlink is used to transfer information about the process and
 	  its parent. This information can be used by a user space application.
 	  The exit connector can be enable/disable by sending a message to the
 	  connector with the corresponding group id.
 
 config FORK_CONNECTOR
 	bool "Enable fork connector"
+	depends on NET
 	select CONNECTOR
 	default y
 	---help---
 	  It adds a connector in kernel/fork.c:do_fork() function. When a fork
 	  occurs, netlink is used to transfer information about the parent and
 	  its child. This information can be used by a user space application.
 	  The fork connector can be enable/disable by sending a message to the
 	  connector with the corresponding group id.
 
 endmenu
#1 lore raw
Quoted 2 lines · Adrian Bunk

If you select some variable, you have to ensure that the dependencies of the select'ed variable are fulfilled.

Correct, thank you.
I've add Guillaume Thouvenin (author) to Cc: list.

Quoted 77 lines

This patch fixes the following link error:

<-- snip -->

...
LD .tmp_vmlinux1
drivers/built-in.o: In function `cn_netlink_send':
: undefined reference to `alloc_skb'
drivers/built-in.o: In function `cn_netlink_send':
: undefined reference to netlink_broadcast' drivers/built-in.o: In function cn_netlink_send':
: undefined reference to __kfree_skb' drivers/built-in.o: In function cn_netlink_send':
: undefined reference to skb_over_panic' drivers/built-in.o: In function cn_rx_skb':
connector.c:(.text+0x20d809): undefined reference to __kfree_skb' drivers/built-in.o: In function cn_input':
connector.c:(.text+0x20d91e): undefined reference to skb_dequeue' drivers/built-in.o: In function cn_init':
connector.c:(.text+0x20dedc): undefined reference to `netlink_kernel_create'
connector.c:(.text+0x20df67): undefined reference to sock_release' drivers/built-in.o: In function kfree_skb':
connector.c:(.text+0x20d756): undefined reference to __kfree_skb' drivers/built-in.o: In function cn_rx_skb':
connector.c:(.text+0x20d7c8): undefined reference to __kfree_skb' connector.c:(.text+0x20d87e): undefined reference to __kfree_skb' drivers/built-in.o: In function `cn_fini':
connector.c:(.text+0x20dfae): undefined reference to sock_release' drivers/built-in.o: In function w1_alloc_dev':
make: *** [.tmp_vmlinux1] Error 1

<-- snip -->

drivers/connector/Kconfig renamed from drivers/connector/Kconfig.old +2 -0
@@ -1,35 +1,37 @@
 menu "Connector - unified userspace <-> kernelspace linker"
 
 config CONNECTOR
 	tristate "Connector - unified userspace <-> kernelspace linker"
 	depends on NET
 	---help---
 	  This is unified userspace <-> kernelspace connector working on top
 	  of the netlink socket protocol.
 
 	  Connector support can also be built as a module.  If so, the module
 	  will be called cn.ko.
 
 config EXIT_CONNECTOR
 	bool "Enable exit connector"
+	depends on NET
 	select CONNECTOR
 	default y
 	---help---
 	  It adds a connector in kernel/exit.c:do_exit() function. When a exit
 	  occurs, netlink is used to transfer information about the process and
 	  its parent. This information can be used by a user space application.
 	  The exit connector can be enable/disable by sending a message to the
 	  connector with the corresponding group id.
 
 config FORK_CONNECTOR
 	bool "Enable fork connector"
+	depends on NET
 	select CONNECTOR
 	default y
 	---help---
 	  It adds a connector in kernel/fork.c:do_fork() function. When a fork
 	  occurs, netlink is used to transfer information about the parent and
 	  its child. This information can be used by a user space application.
 	  The fork connector can be enable/disable by sending a message to the
 	  connector with the corresponding group id.
 
 endmenu
Signature · 1 line
	Evgeniy Polyakov