fix suspend/resume irq request free for yenta..
hi
the patch is wrong. yenta_request_irq() registers the wrong handler. plus yenta_probe_cb_irq() has nothing to do with suspend/resume (besides it frees the irq in the very same function). correct patch below.
somebody cares to explain me why the free_irq() is necessary before a suspend?
rgds
-daniel
---------------
[PATCH] yenta: free_irq() on suspend.
Resume doesn't seem to work without.
Signed-off-by Daniel Ritz <[email protected]>
drivers/pcmcia/yenta_socket.c +9 -0
@@ -1107,6 +1107,8 @@ static int yenta_dev_suspend (struct pcipci_read_config_dword (dev,17 *4 , &socket->saved_state[1 ]);pci_disable_device (dev); +free_irq (dev->irq, socket); +/* * Some laptops (IBM T22) do not like us putting the Cardbus * bridge into D3. At a guess, some other laptop will
@@ -1132,6 +1134,13 @@ static int yenta_dev_resume (struct pci_pci_enable_device (dev);pci_set_master (dev); +if (socket->cb_irq) +if (request_irq (socket->cb_irq, yenta_interrupt, +SA_SHIRQ ,"yenta" , socket)) { +printk (KERN_WARNING "Yenta: request_irq() failed on resume!\n" ); + socket->cb_irq =0 ; + } +if (socket->type && socket->type->restore_state) socket->type->restore_state (socket); }